[PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

Otherwise the backlight can't be changed, presumably because the DSDT
contains stub code when in conjunction with Windows 8.

https://wiki.archlinux.org/index.php/ASUS_Zenbook_Prime_UX31A

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 drivers/acpi/blacklist.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index cb96296..a404127 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -192,6 +192,12 @@ static int __init dmi_disable_osi_win7(const struct dmi_system_id *d)
 	acpi_osi_setup("!Windows 2009");
 	return 0;
 }
+static int __init dmi_disable_osi_win8(const struct dmi_system_id *d)
+{
+	printk(KERN_NOTICE PREFIX "DMI detected: %s\n", d->ident);
+	acpi_osi_setup("!Windows 2012");
+	return 0;
+}
 
 static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 	{
@@ -267,6 +273,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "Satellite P305D"),
 		},
 	},
+	{
+	.callback = dmi_disable_osi_win8,
+	.ident = "ASUS Zenbook Prime UX31A",
+	.matches = {
+		     DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+		     DMI_MATCH(DMI_PRODUCT_NAME, "UX31A"),
+		},
+	},
 
 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
-- 
1.8.3.rc3.286.g3d43083

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

On Mon, May 20, 2013 at 3:16 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Otherwise the backlight can't be changed, presumably because the DSDT
> contains stub code when in conjunction with Windows 8.
>
> https://wiki.archlinux.org/index.php/ASUS_Zenbook_Prime_UX31A
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

Hello?

Is there anything wrong with this patch?

-- 
Felipe Contreras

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Rafael J. Wysocki]

On Wednesday, June 26, 2013 05:41:01 AM Felipe Contreras wrote:
> On Mon, May 20, 2013 at 3:16 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > Otherwise the backlight can't be changed, presumably because the DSDT
> > contains stub code when in conjunction with Windows 8.
> >
> > https://wiki.archlinux.org/index.php/ASUS_Zenbook_Prime_UX31A
> >
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> 
> Hello?
> 
> Is there anything wrong with this patch?

We're going to fix this issue in a different way.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Aaron Lu]

On 06/26/2013 08:42 PM, Rafael J. Wysocki wrote:
> On Wednesday, June 26, 2013 05:41:01 AM Felipe Contreras wrote:
>> On Mon, May 20, 2013 at 3:16 AM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>> Otherwise the backlight can't be changed, presumably because the DSDT
>>> contains stub code when in conjunction with Windows 8.
>>>
>>> https://wiki.archlinux.org/index.php/ASUS_Zenbook_Prime_UX31A
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>
>> Hello?
>>
>> Is there anything wrong with this patch?
> 
> We're going to fix this issue in a different way.

Hi Felipe,

Please reference a similar bug where ACPI video driver can't work for
some thinkpad win8 laptops:
https://bugzilla.kernel.org/show_bug.cgi?id=51231

And the proposed way to fix this issue is for all Win8 systems, the
ACPI video backlight interface will be removed, leaving only GPU's
backlight interface:
https://lkml.org/lkml/2013/6/9/161

Thanks,
Aaron

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

On Wed, Jun 26, 2013 at 9:37 PM, Aaron Lu <aaron.lu@intel.com> wrote:

> Please reference a similar bug where ACPI video driver can't work for
> some thinkpad win8 laptops:
> https://bugzilla.kernel.org/show_bug.cgi?id=51231
>
> And the proposed way to fix this issue is for all Win8 systems, the
> ACPI video backlight interface will be removed, leaving only GPU's
> backlight interface:
> https://lkml.org/lkml/2013/6/9/161

Thanks. I took a look at the thread and the patches, so essentially
when those patches are applied, I should expect the same behavior as
acpi_backlight=vendor, right? If so, that doesn't work correctly in
this laptop. In this laptop intel backlight works through X, but when
I set the level to 0 everything is black (it works fine in ACPI), and
the keyboard keys don't work.

ACPI works perfectly fine. So I think for this laptop (and possibly
others) ACPI without win8 mode is the way to go.

-- 
Felipe Contreras

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Rafael J. Wysocki]

On Wednesday, July 17, 2013 10:42:35 AM Felipe Contreras wrote:
> On Wed, Jun 26, 2013 at 9:37 PM, Aaron Lu <aaron.lu@intel.com> wrote:
> 
> > Please reference a similar bug where ACPI video driver can't work for
> > some thinkpad win8 laptops:
> > https://bugzilla.kernel.org/show_bug.cgi?id=51231
> >
> > And the proposed way to fix this issue is for all Win8 systems, the
> > ACPI video backlight interface will be removed, leaving only GPU's
> > backlight interface:
> > https://lkml.org/lkml/2013/6/9/161

No, that's obsolete already.

I'll let you know what to try when other people confirm it works for them.

> Thanks. I took a look at the thread and the patches, so essentially
> when those patches are applied, I should expect the same behavior as
> acpi_backlight=vendor, right?

I'm not sure about the Matthew's version.

> If so, that doesn't work correctly in
> this laptop. In this laptop intel backlight works through X, but when
> I set the level to 0 everything is black (it works fine in ACPI), and
> the keyboard keys don't work.
> 
> ACPI works perfectly fine. So I think for this laptop (and possibly
> others) ACPI without win8 mode is the way to go.

While that may be the case, I'd like to avoid more blacklisting than we
already have.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

On Wed, Jul 17, 2013 at 5:04 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday, July 17, 2013 10:42:35 AM Felipe Contreras wrote:

>> If so, that doesn't work correctly in
>> this laptop. In this laptop intel backlight works through X, but when
>> I set the level to 0 everything is black (it works fine in ACPI), and
>> the keyboard keys don't work.
>>
>> ACPI works perfectly fine. So I think for this laptop (and possibly
>> others) ACPI without win8 mode is the way to go.
>
> While that may be the case, I'd like to avoid more blacklisting than we
> already have.

Unless your version makes it work without regression from user-space,
I don't see any other option.

-- 
Felipe Contreras

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Rafael J. Wysocki]

On Wednesday, July 17, 2013 07:20:41 PM Felipe Contreras wrote:
> On Wed, Jul 17, 2013 at 5:04 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Wednesday, July 17, 2013 10:42:35 AM Felipe Contreras wrote:
> 
> >> If so, that doesn't work correctly in
> >> this laptop. In this laptop intel backlight works through X, but when
> >> I set the level to 0 everything is black (it works fine in ACPI), and
> >> the keyboard keys don't work.
> >>
> >> ACPI works perfectly fine. So I think for this laptop (and possibly
> >> others) ACPI without win8 mode is the way to go.
> >
> > While that may be the case, I'd like to avoid more blacklisting than we
> > already have.
> 
> Unless your version makes it work without regression from user-space,
> I don't see any other option.

Well, does your machine work correctly with 3.10 with any additional changes?

Rafael

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

On Wed, Jul 17, 2013 at 7:31 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday, July 17, 2013 07:20:41 PM Felipe Contreras wrote:
>> On Wed, Jul 17, 2013 at 5:04 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> > On Wednesday, July 17, 2013 10:42:35 AM Felipe Contreras wrote:
>>
>> >> If so, that doesn't work correctly in
>> >> this laptop. In this laptop intel backlight works through X, but when
>> >> I set the level to 0 everything is black (it works fine in ACPI), and
>> >> the keyboard keys don't work.
>> >>
>> >> ACPI works perfectly fine. So I think for this laptop (and possibly
>> >> others) ACPI without win8 mode is the way to go.
>> >
>> > While that may be the case, I'd like to avoid more blacklisting than we
>> > already have.
>>
>> Unless your version makes it work without regression from user-space,
>> I don't see any other option.
>
> Well, does your machine work correctly with 3.10 with any additional changes?

With my patch, yes. I will try the patches you just sent, but my guess
is that it would work the same as acpi_backlight=vendor (not
correctly).

-- 
Felipe Contreras

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Rafael J. Wysocki]

On Wednesday, July 17, 2013 07:53:10 PM Felipe Contreras wrote:
> On Wed, Jul 17, 2013 at 7:31 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Wednesday, July 17, 2013 07:20:41 PM Felipe Contreras wrote:
> >> On Wed, Jul 17, 2013 at 5:04 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> > On Wednesday, July 17, 2013 10:42:35 AM Felipe Contreras wrote:
> >>
> >> >> If so, that doesn't work correctly in
> >> >> this laptop. In this laptop intel backlight works through X, but when
> >> >> I set the level to 0 everything is black (it works fine in ACPI), and
> >> >> the keyboard keys don't work.
> >> >>
> >> >> ACPI works perfectly fine. So I think for this laptop (and possibly
> >> >> others) ACPI without win8 mode is the way to go.
> >> >
> >> > While that may be the case, I'd like to avoid more blacklisting than we
> >> > already have.
> >>
> >> Unless your version makes it work without regression from user-space,
> >> I don't see any other option.
> >
> > Well, does your machine work correctly with 3.10 with any additional changes?
> 
> With my patch, yes.

And without your patch?  It is not there in 3.10, is it?

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

On Thu, Jul 18, 2013 at 2:19 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday, July 17, 2013 07:53:10 PM Felipe Contreras wrote:
>> On Wed, Jul 17, 2013 at 7:31 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> > On Wednesday, July 17, 2013 07:20:41 PM Felipe Contreras wrote:
>> >> On Wed, Jul 17, 2013 at 5:04 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> >> > On Wednesday, July 17, 2013 10:42:35 AM Felipe Contreras wrote:
>> >>
>> >> >> If so, that doesn't work correctly in
>> >> >> this laptop. In this laptop intel backlight works through X, but when
>> >> >> I set the level to 0 everything is black (it works fine in ACPI), and
>> >> >> the keyboard keys don't work.
>> >> >>
>> >> >> ACPI works perfectly fine. So I think for this laptop (and possibly
>> >> >> others) ACPI without win8 mode is the way to go.
>> >> >
>> >> > While that may be the case, I'd like to avoid more blacklisting than we
>> >> > already have.
>> >>
>> >> Unless your version makes it work without regression from user-space,
>> >> I don't see any other option.
>> >
>> > Well, does your machine work correctly with 3.10 with any additional changes?
>>
>> With my patch, yes.
>
> And without your patch?  It is not there in 3.10, is it?

Without my patch backlight control doesn't work at all (unless you do
acpi_osi="!Windows 2012").

-- 
Felipe Contreras

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Aaron Lu]

On 07/17/2013 11:42 PM, Felipe Contreras wrote:
> On Wed, Jun 26, 2013 at 9:37 PM, Aaron Lu <aaron.lu@intel.com> wrote:
> 
>> Please reference a similar bug where ACPI video driver can't work for
>> some thinkpad win8 laptops:
>> https://bugzilla.kernel.org/show_bug.cgi?id=51231
>>
>> And the proposed way to fix this issue is for all Win8 systems, the
>> ACPI video backlight interface will be removed, leaving only GPU's
>> backlight interface:
>> https://lkml.org/lkml/2013/6/9/161
> 
> Thanks. I took a look at the thread and the patches, so essentially
> when those patches are applied, I should expect the same behavior as
> acpi_backlight=vendor, right? If so, that doesn't work correctly in
> this laptop. In this laptop intel backlight works through X, but when
> I set the level to 0 everything is black (it works fine in ACPI), and

That sounds a bug in i915's handling of backlight to me, perhaps file a
bug for that? For component, please choose Drivers/DRI-intel.

> the keyboard keys don't work.

I don't see why the backlight hotkey stops working, we have kept ACPI's
event notification handling for Win8 systems. Worth filing a bug too :-)
For components, please choose ACPI/Video.

BTW, what's the situation after you try the following 3 patches:
https://patchwork.kernel.org/patch/2829342/
https://patchwork.kernel.org/patch/2829344/
https://patchwork.kernel.org/patch/2829339/

Thanks,
Aaron

Re: [PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A

[Felipe Contreras]

On Wed, Jun 26, 2013 at 7:42 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Wednesday, June 26, 2013 05:41:01 AM Felipe Contreras wrote:
>> On Mon, May 20, 2013 at 3:16 AM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>> > Otherwise the backlight can't be changed, presumably because the DSDT
>> > contains stub code when in conjunction with Windows 8.
>> >
>> > https://wiki.archlinux.org/index.php/ASUS_Zenbook_Prime_UX31A
>> >
>> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>
>> Hello?
>>
>> Is there anything wrong with this patch?
>
> We're going to fix this issue in a different way.

That "different way" doesn't work correctly.

-- 
Felipe Contreras