From: Tang Chen <tangchen@cn.fujitsu.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
lenb@kernel.org, rjw@sisk.pl, liwanp@linux.vnet.ibm.com,
tj@kernel.org, akpm@linux-foundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 6/6] acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment.
Date: Tue, 20 Aug 2013 09:19:34 +0800 [thread overview]
Message-ID: <5212C426.7020006@cn.fujitsu.com> (raw)
In-Reply-To: <1376940579.10300.474.camel@misato.fc.hp.com>
On 08/20/2013 03:29 AM, Toshi Kani wrote:
> On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote:
>> The comment about return value of acpi_table_parse() is incorrect.
>> This patch fix it.
>>
>> Furthermore, if the table is not found, return 1 means nothing, and
>> make it difficult to write the comment. So return -ENOENT when the
>> table is not found, and correct the comment.
>
> I am OK with the change, but the above description is not very clear.
> You should state that all callers only check if the function succeeded
> or not. So, you are simplifying the semantics by returning -errno for
> all failure cases.
>
> Since you are making this change, I'd suggest you also update the stub
> function in linux/acpi.h to return -ENODEV as well.
OK, followed. And will merge patch 3 and 4 and resend them later.
Thanks for reviewing.
prev parent reply other threads:[~2013-08-20 1:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 7:06 [PATCH 0/6] acpi: Fix and cleanup in acpi Tang Chen
2013-08-16 7:06 ` [PATCH 1/6] acpi, numa, mem_hotplug: Kill save_add_info() Tang Chen
2013-08-19 18:48 ` Toshi Kani
2013-08-16 7:06 ` [PATCH 2/6] acpi, numa, mem_hotplug: Print Hot-Pluggable Field in SRAT Tang Chen
2013-08-19 18:48 ` Toshi Kani
2013-08-16 7:06 ` [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c Tang Chen
2013-08-16 7:25 ` Joe Perches
2013-08-16 7:58 ` Tang Chen
2013-08-16 10:11 ` Tang Chen
2013-08-16 10:11 ` [PATCH 4/6] acpi cleanup: Use pr_err() " Tang Chen
2013-08-19 18:53 ` [PATCH 3/6] acpi cleanup: Use pr_info() " Toshi Kani
2013-08-16 7:06 ` [PATCH 4/6] acpi cleanup: Use pr_err() " Tang Chen
2013-08-16 7:06 ` [PATCH 5/6] acpi: Check if @id is NULL in acpi_table_parse() Tang Chen
2013-08-19 19:29 ` Toshi Kani
2013-08-16 7:06 ` [PATCH 6/6] acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment Tang Chen
2013-08-19 19:29 ` Toshi Kani
2013-08-20 1:19 ` Tang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5212C426.7020006@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox