From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48397242910; Sun, 4 Oct 2026 08:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791100879; cv=none; b=F3nwidsUrPEszSKJk73MX19lDT7DmtqIaFiYBVOpWYAbX+m5UhyXRWCg77OPUwO1caM7ZT2awVtZPL8sRHrVN3q6bqOoZPRZsGIIE2orMk1W8bvDS5AFTCmRY42k0vV8SfUOPcyxZwLW/750pDftzdfPUK5IKNuE/wvfCD95gBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791100879; c=relaxed/simple; bh=9M3x7X8al5SvKY4/uuzHfOHfRDjeMR648jQnVaDLq+w=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=SYTlqtC5/128R6kjCU17KwXIPXrp25xTEtkIpkIx+p1V/xji9rlFxtXiM9bmXb4idT2/i3WgcmyG+tEXrkXBpN10PWPE6OBbHvG+qRC4yuFWIBKGYR+LMD1kp9kXBdPJmgH/eZR0KNCovkToKfSceBpouqSoh8isAoTkkpSYC8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DB3jQL0Z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DB3jQL0Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2CC71F00893; Sun, 4 Oct 2026 08:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791100877; bh=F9kBSf7wm8l5Shredw3rUxbEz7kCjNDe52nqsiHGf7c=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=DB3jQL0Z5l9B2Qktkhd2yiwYXiFgT+WC5v0pCYcP8ijR3Oa+7tzqOvuuFM2Wyd7lz GJvqAZTm0YLxyyPMbbzbiPjMI3aHVKOFH9cyS4wvrCGy84Z+lhgYE9oKzejTZBp8N3 35clbC7Z6dShfZiZebtBXN7KQ/o6b96h/ifyWnujmhk2xPhlkhLKvFzKI1r/2TWaML zEiwoyk8jbgnN69zWoq7jtQ9A8TmuzSNd+7il9unnfZvnW0LBU4E//qpWRUr6Pmj8L Que8kKANCoY8ewm87Zpym+10wTp1T2ph4aU08AWoLU+r0GFoI83aWYc0CH6yOqjAMu WzgraX0Ssl6kw== Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id 5220E198003A; Sun, 4 Oct 2026 04:01:14 -0400 (EDT) Received: from ams-imap-11 ([10.64.2.31]) by ams-compute-02.internal (MEProxy); Sun, 04 Oct 2026 04:01:14 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTF7bRBgwhxff1sp0njzeucjRIZKeidM1lEvn3ZkcmfabbQS21vmUcl/545EvBZxYC zmeS4tx/0rEzZEMw3ccK+pwEOxmlfLHDn+oPtpWd5pOzFhWZ8qx0nN1aELo4ar9rn24ijj lt8/erIwFtrzSrAHD113d22ZYP8CFMJmR/vDmycv/nC2SeWpI9uH5xe/IEscARpoJxgo46 FJv1pR6b9wBRLtsf81TURnFMk8GOO51bYmfLKA142e69wg5DdI/KUAwLwfVSgyRCgJF6WE BL4Qhsvf7BTn5Mh2kVIGZnS/KllKOa3Dm3r+PB37qaKuRaOSVAsz9QxnDOVGQ8hf8CEFfH abwBjdSx8Nnjut7m2nkZzlH/6bsc6PLml+YXqrkIsy4Iy73vIjS5gdD+w8R3Dd1VLIalF1 JZSd7edsqIb/gBKQZ+h2jjgU7KLM4Oab/A+4fazFPOH7jaIruJVZPUOjtHfXOzaCMIvYnm KoB1sgpVxHBxni6yuuQtuYamVXhQkBMYmc6YAILTmxYTiLqIp5uG4kv5XNQGD+yuXfuZPa VOR95jGwFdW5IhZKkce6jsBhvCmzs5QONFECOW1LQbtAT5T0vCOwUOZRHeO66Qs3wQ5U9Y WnTO5s8R+uyUsgLdrKlklFCL/KmCKg7R1uJkRPbFIAtlS31F8Yj98JDGX+CQ X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 05795F80096; Sun, 4 Oct 2026 04:01:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sun, 04 Oct 2026 10:00:50 +0200 From: "Ard Biesheuvel" To: =?UTF-8?Q?Kristina_Mart=C5=A1enko?= , linux-arm-kernel@lists.infradead.org, "Linux ACPI" , kvmarm@lists.linux.dev, linux-efi@vger.kernel.org Cc: "Catalin Marinas" , "Will Deacon" , "Mark Rutland" , "Ryan Roberts" , "David Hildenbrand" , "Lorenzo Stoakes" , "Linu Cherian" , "Anshuman Khandual" , "Lorenzo Pieralisi" , "Hanjun Guo" , "Sudeep Holla" , "Marc Zyngier" , "Oliver Upton" , "Fuad Tabba" , "Joey Gouly" , "Steffen Eiden" , "Suzuki K Poulose" , "Zenghui Yu" , "Ilias Apalodimas" Message-Id: <52231d93-98f9-4413-9e0d-4bc7ec7666db@app.fastmail.com> In-Reply-To: <20261001110655.461473-9-kristina.martsenko@arm.com> References: <20261001110655.461473-1-kristina.martsenko@arm.com> <20261001110655.461473-9-kristina.martsenko@arm.com> Subject: Re: [RFC 08/12] efi/arm: Check return value of init_new_context() Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, 1 Oct 2026, at 13:06, Kristina Mart=C5=A1enko wrote: > init_new_context() will soon be able to return an error. Check for > errors before continuing. > > Signed-off-by: Kristina Mart=C5=A1enko > --- > drivers/firmware/efi/arm-runtime.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/arm-runtime.c=20 > b/drivers/firmware/efi/arm-runtime.c > index 3167cab62014..7ef29cd0bfb7 100644 > --- a/drivers/firmware/efi/arm-runtime.c > +++ b/drivers/firmware/efi/arm-runtime.c > @@ -55,7 +55,8 @@ static bool __init efi_virtmap_init(void) >=20 > efi_mm.pgd =3D pgd_alloc(&efi_mm); > mm_init_cpumask(&efi_mm); > - init_new_context(NULL, &efi_mm); > + if (init_new_context(NULL, &efi_mm)) > + return false; >=20 Can we make this a WARN_ON() so any failures are not misidentified as invalid or missing virtual mappings? With that, Acked-by: Ard Biesheuvel