From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8 Date: Tue, 10 Sep 2013 11:27:34 +0800 Message-ID: <522E91A6.6040600@intel.com> References: <522D88C3.7000808@intel.com> <522D89EC.6050103@intel.com> <1378727093.13401.3.camel@ThinkPad-X230.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:5537 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925Ab3IJD1D (ORCPT ); Mon, 9 Sep 2013 23:27:03 -0400 In-Reply-To: <1378727093.13401.3.camel@ThinkPad-X230.localdomain> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Igor Gnatenko Cc: ACPI Devel Mailing List , "Rafael J. Wysocki" , Matthew Garrett , Seth Forshee , "Lee, Chun-Yi" , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Len Brown , Yves-Alexis Perez , Felipe Contreras , Lee Chun-Yi , Henrique de Moraes Holschuh On 09/09/2013 07:44 PM, Igor Gnatenko wrote: > On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: >> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c >> index f466980..75fba17 100644 >> --- a/drivers/gpu/drm/i915/i915_dma.c >> +++ b/drivers/gpu/drm/i915/i915_dma.c >> @@ -1650,7 +1650,7 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) >> if (INTEL_INFO(dev)->num_pipes) { >> /* Must be done after probing outputs */ >> intel_opregion_init(dev); >> - acpi_video_register(); >> + __acpi_video_register(i915_take_over_backlight); >> } >> >> if (IS_GEN5(dev)) > > I can't compile: > > > DEBUG: drivers/gpu/drm/i915/i915_dma.c: In function 'i915_driver_load': > DEBUG: drivers/gpu/drm/i915/i915_dma.c:1661:3: error: implicit > declaration of function > '__acpi_video_register' [-Werror=implicit-function-declaration] > DEBUG: __acpi_video_register(i915_take_over_backlight); > DEBUG: ^ > DEBUG: cc1: some warnings being treated as errors > DEBUG: make[4]: *** [drivers/gpu/drm/i915/i915_dma.o] Error 1 > DEBUG: make[3]: *** [drivers/gpu/drm/i915] Error 2 > DEBUG: make[2]: *** [drivers/gpu/drm] Error 2 > DEBUG: make[1]: *** [drivers/gpu] Error 2 > DEBUG: make: *** [drivers] Error 2 > The two patches are based on top of Rafael's linux-next tree. I just tried it again, no compile problem for me. I also tried on today Linus' master tree, as there are some updates from i915, two conflicts exist. I've just resolved them and will update it in next revision. If you want to try it now, please use: https://github.com/aaronlu/linux acpi_video_rework Thanks, Aaron