From: Aaron Lu <aaron.lu@intel.com>
To: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Cc: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Matthew Garrett <matthew.garrett@nebula.com>,
Seth Forshee <seth.forshee@canonical.com>,
Lee Chun-Yi <joeyli.kernel@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Yves-Alexis Perez <corsac@debian.org>,
Felipe Contreras <felipe.contreras@gmail.com>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 0/3] Fix Win8 backlight issue
Date: Sun, 22 Sep 2013 17:10:59 +0800 [thread overview]
Message-ID: <523EB423.7090900@intel.com> (raw)
In-Reply-To: <1379507774.2294.21.camel@ThinkPad-X230.localdomain>
On 09/18/2013 08:36 PM, Igor Gnatenko wrote:
> On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote:
>> On 09/18/2013 02:30 PM, Igor Gnatenko wrote:
>>> On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote:
>>>> On 09/17/2013 09:34 PM, Igor Gnatenko wrote:
>>>>>
>>>>> Aaron, how about fix indicator on ThinkPads ?
>>>>
>>>> Can you please describe the problem in detail, is it that when you
>>>> adjust brightness level through hotkey, there is no GUI indication?
>>>> Thanks.
>>>>
>>>> -Aaron
>>>
>>> Yes. On my ThinkPad X230 I pressing backlight hotkeys. Actually
>>> brightnes changing, but have no indicator in GUI.
>>
>> Oh, that's still the problem of _BCL not getting executed once for
>> Lenovo thinkpad laptops. I borrowed a Thinkpad X1 this afternoon and can
>> reproduce this, I'll take a look at this issue. The thinkpad-acpi module
>> already has a call to _BCL but somehow that doesn't happen.
>>
>> Since it's national holidays here, I'll check this issue when I got back
>> to work on this Saturday. Thanks for the quick test :-)
> Thanks. No problem ;-)
Here is a quick fix for thinkpad-acpi.c:
https://github.com/aaronlu/linux acpi_video_win8
commit thinkpad-acpi: fix handle locate for video and query of _BCL.
Note that it is a separate issue specifically for thinkpad so I'll
submit that patch in another thread.
Thanks,
Aaron
next prev parent reply other threads:[~2013-09-22 9:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 9:23 [PATCH v2 0/3] Fix Win8 backlight issue Aaron Lu
2013-09-17 9:23 ` [PATCH v2 1/3] backlight: introduce backlight_device_registered Aaron Lu
2013-09-17 13:03 ` Igor Gnatenko
2013-09-20 13:01 ` Yves-Alexis Perez
2013-09-17 9:23 ` [PATCH v2 2/3] ACPI / video: seperate backlight control and event interface Aaron Lu
2013-09-17 13:04 ` Igor Gnatenko
2013-09-20 13:01 ` Yves-Alexis Perez
2013-09-17 9:23 ` [PATCH v2 3/3] ACPI / video: Do not register backlight if win8 and native interface exists Aaron Lu
2013-09-17 13:04 ` Igor Gnatenko
2013-09-20 8:36 ` Jani Nikula
2013-09-22 2:47 ` Aaron Lu
2013-09-20 13:02 ` Yves-Alexis Perez
2013-09-17 13:34 ` [PATCH v2 0/3] Fix Win8 backlight issue Igor Gnatenko
2013-09-18 1:03 ` Aaron Lu
2013-09-18 6:30 ` Igor Gnatenko
2013-09-18 12:31 ` Aaron Lu
2013-09-18 12:36 ` Igor Gnatenko
2013-09-22 9:10 ` Aaron Lu [this message]
2013-09-22 10:23 ` Igor Gnatenko
2013-09-20 13:00 ` Yves-Alexis Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523EB423.7090900@intel.com \
--to=aaron.lu@intel.com \
--cc=corsac@debian.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipe.contreras@gmail.com \
--cc=i.gnatenko.brain@gmail.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joeyli.kernel@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).