From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prarit Bhargava Subject: Re: [PATCH 1/2] ACPI / PCI: don't allow PCI devices without irq to be enabled Date: Thu, 03 Oct 2013 19:58:57 -0400 Message-ID: <524E04C1.7010605@redhat.com> References: <1375965314-24232-1-git-send-email-heikki.krogerus@linux.intel.com> <1375965314-24232-2-git-send-email-heikki.krogerus@linux.intel.com> <14983102.aCV009CSMA@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36634 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216Ab3JCX7H (ORCPT ); Thu, 3 Oct 2013 19:59:07 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Bjorn Helgaas Cc: Yinghai Lu , "Rafael J. Wysocki" , Heikki Krogerus , "linux-acpi@vger.kernel.org" , Linux PCI , Sarah Sharp , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" On 08/12/2013 06:32 PM, Bjorn Helgaas wrote: > On Mon, Aug 12, 2013 at 3:32 PM, Yinghai Lu wrote: >> On Mon, Aug 12, 2013 at 2:14 PM, Bjorn Helgaas wrote: >>> On Thu, Aug 8, 2013 at 7:57 AM, Rafael J. Wysocki wrote: >>>> On Thursday, August 08, 2013 03:35:13 PM Heikki Krogerus wrote: >>>>> If there is no ACPI entry for the irq, returning error from >>>>> acpi_pci_enable_irq() if the irq is 0. >>>>> >>>>> Prarit Bhargava reported an issue where he noticed that his >>>>> Dell PowerEdge 840 has buggy BIOS that does not supply ACPI >>>>> entries for irq with some devices. That lead into kernel >>>>> generating a warning "genirq: Flags mismatch irq 0...". This >>>>> will fix that issue. >>>>> >>>>> Signed-off-by: Heikki Krogerus >>>>> Tested-by: Prarit Bhargava >>>> >>>> Hi Bjorn, >>>> >>>> Any objections to this? >>> >>> Acked-by: Bjorn Helgaas >> >> some USB3 host controller does not have intx configured, but still >> work with MSI? > > Huh, OK, I take back my ack, at least while we investigate this. > Bjorn, as suggested I've opened up a BZ here: https://bugzilla.kernel.org/show_bug.cgi?id=62521 I've only cc'd yourself and Rafael. Heikki -- I didn't find an account under your intel.com address ... P.