From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices Date: Mon, 14 Oct 2013 09:34:39 +0300 Message-ID: <525B907F.1020203@linux.intel.com> References: <1381414669-26115-1-git-send-email-jarkko.nikula@linux.intel.com> <20131011144946.GS3521@intel.com> <2393462.4JRAMNeigd@vostro.rjw.lan> <20131012050413.GY3521@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:56716 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917Ab3JNGfC (ORCPT ); Mon, 14 Oct 2013 02:35:02 -0400 In-Reply-To: <20131012050413.GY3521@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Mika Westerberg Cc: "Rafael J. Wysocki" , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, Wolfram Sang On 10/12/2013 08:04 AM, Mika Westerberg wrote: > On Sat, Oct 12, 2013 at 12:16:02AM +0200, Rafael J. Wysocki wrote: >>> I think that this is intentional. We don't want that the i2c modalias >>> matches with the ACPI device (like with the i2c:INTABCD). Instead use ACPI >>> IDs that are added to the driver to match with the ACPI device. >> Well, I'm not really sure this was intentional, but I wonder how other bus >> types work in that respect? > We have the same for platform bus, if that's what you are asking. > Do we? I don't recall seeing per device modaliases on other platforms on their platform buses. And actually I don't see that happening in drivers/base/platform.c: platform_uevent() either where just pdev->name is used but not pdev->id (which is used with pdev->name for dev_set_name()). This makes me thinking that perhaps "pdevinfo.name = dev_name(&adev->dev);" in drivers/acpi/acpi_platform.c: acpi_create_platform_device() should be fixed too as now modalias for ACPI registered platform devices differ from platform devices that are registered in other subsystems (e.g. regulatory, pcspkr, alarmtimer, etc devices)? I can send a patch for that. -- Jarkko