Re: [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices

[Jarkko Nikula <jarkko.nikula@linux.intel.com>]

On 10/14/2013 12:23 PM, Zhang Rui wrote:
> Hi,
>
> On Thu, 2013-10-10 at 17:17 +0300, Jarkko Nikula wrote:
>> There is a minor fault about ACPI enumerated I2C devices with their modalias
>> attribute. Now modalias is set by device instance not by hardware ID.
>> For example "i2c:INTABCD:00", "i2c:INTABCD:01" etc.
>>
>> This means each device instance gets different modalias which does match
>> with generated modules.alias. Currently this is not problem as matching can
>> happen also with "acpi:INTABCD" modalias.
>>
> IMO, this is not the proper fix for the modalias problem because ACPI
> enumerated I2C device may have compatible ids.
> Instead, we should export all the compatible ids as the modules alias of
> the ACPI enumerated I2C device.
>
> can you please take a look at the patch I sent out earlier?
> https://patchwork.kernel.org/patch/3034991/
> https://patchwork.kernel.org/patch/3035041/
> https://patchwork.kernel.org/patch/3035021/
I see. This makes sense as it avoids that same device has two different 
modaliases from both acpi and other subsystem.

How about modalias nodes in sysfs, should they also reflect what is 
matching uvent?

-- 
Jarkko