From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Anderson, Brandon" <Brandon.Anderson@amd.com>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Cc: "lenb@kernel.org" <lenb@kernel.org>, "rjw@sisk.pl" <rjw@sisk.pl>,
"naresh.bhat@linaro.org" <naresh.bhat@linaro.org>,
"graeme.gregory@linaro.org" <graeme.gregory@linaro.org>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
Subject: Re: [RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource
Date: Wed, 23 Oct 2013 15:37:47 +0800 [thread overview]
Message-ID: <52677CCB.7090508@linaro.org> (raw)
In-Reply-To: <CE40542A5D952D47989966E71788B1840156EDDB@satlexdag05.amd.com>
On 2013-10-23 8:13, Anderson, Brandon wrote:
> Is the proposed ASL format appropriate? I recognize that the ASL
It is ok for me. it represents the device topology very clear also.
> definitions for these devices must be standardized across all ARM ACPI
> platform definitions if we want the software to work consistently,
> so this is an important aspect to agree upon.
>
> How about contrasting it with an alternative where each device has _HID
> of "AMBA0000" and there's no top-level 'Device (AMBA)'? This would mean
> that all the devices would be labeled by ACPI subsystem as "AMBA0000:NN"
> instead of "device:NN". However, with this solution there would be no easy
> way to define a default clock. See example below.
I think a top-level 'Device (AMBA)' is needed. there is a good example
for PCI host bridge, its HID is PNP0A08 or PNP0A03, and there are a top level
device for PCI host bridge and child devices with different HIDs.
if there's no top-level 'Device (AMBA)', AMBA0000:NN will confuse people if
there are multi AMBAs in the system, people will think that AMBA0000:01 is
the second AMBA bus in the system but not some devices under AMBA bus.
Thanks
Hanjun
next prev parent reply other threads:[~2013-10-23 7:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 0:33 [RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource brandon.anderson
2013-10-22 0:33 ` [RFC PATCH 1/3] ACPI: Remove UART and KMI entries from DTS file brandon.anderson
2013-10-23 11:28 ` Hanjun Guo
2013-10-22 0:33 ` [RFC PATCH 2/3] ACPI: Prototype of AMBA bus 'connector resource' brandon.anderson
2013-10-23 11:52 ` Hanjun Guo
2013-10-23 12:49 ` Graeme Gregory
2013-10-23 15:32 ` Anderson, Brandon
2013-10-22 0:33 ` [RFC PATCH 3/3] ACPI: Hack clock names to get prototype running brandon.anderson
2013-10-22 8:20 ` [RFC PATCH 0/3] ACPI: ARM AMBA bus connector resource Naresh Bhat
2013-10-22 8:41 ` Graeme Gregory
2013-10-22 9:19 ` Naresh Bhat
2013-10-22 8:42 ` Graeme Gregory
2013-10-23 0:13 ` Anderson, Brandon
2013-10-23 7:37 ` Hanjun Guo [this message]
2013-10-23 15:44 ` Anderson, Brandon
2013-10-23 9:44 ` Naresh Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52677CCB.7090508@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=Brandon.Anderson@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=graeme.gregory@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=naresh.bhat@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).