From: Aaron Lu <aaron.lu@intel.com>
To: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Cc: "James Hogan" <james@albanarts.com>,
"Mike Galbraith" <bitbucket@online.de>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Matthew Garrett" <matthew.garrett@nebula.com>,
linux-acpi@vger.kernel.org, "Kalle Valo" <kvalo@adurom.com>,
"Yves-Alexis Perez" <corsac@debian.org>,
"Martin Steigerwald" <Martin@lichtvoll.de>,
"Lee Chun-Yi" <joeyli.kernel@gmail.com>,
"Ben Jencks" <ben@bjencks.net>, "Jörg Otte" <jrg.otte@gmail.com>,
intel-gfx@lists.freedesktop.org,
"Kevin Smith" <thirdwiggin@gmail.com>,
"Peter Weber" <bugs@ttyhoney.com>,
"Joerg Platte" <jplatte@naasa.net>,
"Seth Forshee" <seth.forshee@canonical.com>,
"Lennart Poettering" <lennart@poettering.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Aaron Lu" <aaron.lu@intel.com>, "Theodore Tso" <tytso@mit.edu>
Subject: Re: [PATCH v5 0/4] Fix Win8 backlight issue
Date: Mon, 28 Oct 2013 10:45:43 +0800 [thread overview]
Message-ID: <526DCFD7.7060002@intel.com> (raw)
In-Reply-To: <1382682925.3328.4.camel@ThinkPad-X230.localdomain>
On 10/25/2013 02:35 PM, Igor Gnatenko wrote:
> Aaron, add this notebook to list. I've CC'ed owner.
> And I've tested this patch on my TP X230 (add as Reported-and-Tested me
> please)
> + {
> + .callback = video_set_use_native_backlight,
> + .ident = "Dell Inspiron 7520",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"),
> + },
> + },
Thanks Igor, updated patch follows:
From: Aaron Lu <aaron.lu@intel.com>
Subject: [PATCH] ACPI / video: Add systems that should favour native backlight
interface
Some system's ACPI video backlight control interface is broken and the
native backlight control interface should be used by default. This patch
sets the use_native_backlight parameter to true for those systems so
that video backlight control interface will not be created. To be
specific, the ThinkPad T430s/X230, Lenovo Yoga 13 and Dell Inspiron 7520
are added here.
Thinkpad T430s:
Reported-by: Theodore Tso <tytso@mit.edu>
Reported-and-tested-by: Peter Weber <bugs@ttyhoney.com>
Thinkpad X230:
Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Lenovo Yoga 13:
Reported-by: Lennart Poettering <lennart@poettering.net>
Reported-and-tested-by: Kevin Smith <thirdwiggin@gmail.com>
Dell Inspiron 7520:
Reported-by: Renat Ibragimov <ibragimovrinat@mail.ru>
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
drivers/acpi/video.c | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index d020df5..0a1b030 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -412,6 +412,12 @@ static int video_ignore_initial_backlight(const struct dmi_system_id *d)
return 0;
}
+static int __init video_set_use_native_backlight(const struct dmi_system_id *d)
+{
+ use_native_backlight = true;
+ return 0;
+}
+
static struct dmi_system_id video_dmi_table[] __initdata = {
/*
* Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
@@ -504,6 +510,38 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"),
},
},
+ {
+ .callback = video_set_use_native_backlight,
+ .ident = "ThinkPad T430s",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430s"),
+ },
+ },
+ {
+ .callback = video_set_use_native_backlight,
+ .ident = "ThinkPad X230",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X230"),
+ },
+ },
+ {
+ .callback = video_set_use_native_backlight,
+ .ident = "Lenovo Yoga 13",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo IdeaPad Yoga 13"),
+ },
+ },
+ {
+ .callback = video_set_use_native_backlight,
+ .ident = "Dell Inspiron 7520",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"),
+ },
+ },
{}
};
--
1.8.4.39.ga0d3f10
next prev parent reply other threads:[~2013-10-28 2:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 13:27 [PATCH v5 0/4] Fix Win8 backlight issue Aaron Lu
2013-10-11 13:27 ` [PATCH v5 1/4] backlight: introduce backlight_device_registered Aaron Lu
2013-10-11 13:27 ` [PATCH v5 2/4] ACPI / video: seperate backlight control and event interface Aaron Lu
2013-10-11 13:27 ` [PATCH v5 3/4] ACPI / video: Do not register backlight if win8 and native interface exists Aaron Lu
2013-10-11 13:27 ` [PATCH v5 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL Aaron Lu
2013-10-11 16:42 ` [PATCH v5 0/4] Fix Win8 backlight issue Josh Boyer
2013-10-11 21:01 ` Igor Gnatenko
2013-10-11 22:10 ` Rafael J. Wysocki
2013-10-11 22:01 ` Josh Boyer
2013-10-11 22:45 ` Rafael J. Wysocki
2013-10-11 22:53 ` Igor Gnatenko
2013-10-11 23:10 ` Rafael J. Wysocki
2013-10-11 23:27 ` Rafael J. Wysocki
2013-10-12 5:54 ` Yves-Alexis Perez
2013-10-12 14:10 ` Rafael J. Wysocki
2013-10-12 11:44 ` Josh Boyer
2013-10-12 13:34 ` Seth Forshee
2013-10-12 14:08 ` Rafael J. Wysocki
2013-10-12 6:00 ` Yves-Alexis Perez
2013-10-12 11:47 ` Josh Boyer
2013-10-15 23:33 ` Rafael J. Wysocki
2013-10-24 8:13 ` Aaron Lu
2013-10-25 6:35 ` Igor Gnatenko
2013-10-28 2:45 ` Aaron Lu [this message]
2013-10-28 8:09 ` Jani Nikula
2013-10-29 7:18 ` Aaron Lu
2013-11-15 6:07 ` [PATCH v2] ACPI / video: Add systems that should favor native backlight interface Aaron Lu
2013-11-20 20:56 ` Igor Gnatenko
2013-11-21 5:29 ` [PATCH v2 rebased] " Aaron Lu
2013-12-24 12:20 ` Igor Gnatenko
2013-12-24 13:59 ` Igor Gnatenko
2013-10-30 0:40 ` [PATCH v5 0/4] Fix Win8 backlight issue Matthew Garrett
2013-10-30 0:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526DCFD7.7060002@intel.com \
--to=aaron.lu@intel.com \
--cc=Martin@lichtvoll.de \
--cc=ben@bjencks.net \
--cc=bitbucket@online.de \
--cc=bugs@ttyhoney.com \
--cc=corsac@debian.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=felipe.contreras@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=i.gnatenko.brain@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=james@albanarts.com \
--cc=joeyli.kernel@gmail.com \
--cc=jplatte@naasa.net \
--cc=jrg.otte@gmail.com \
--cc=kvalo@adurom.com \
--cc=lennart@poettering.net \
--cc=linux-acpi@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=thirdwiggin@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).