linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Alex Hung <alex.hung@canonical.com>,
	rui.zhang@intel.com, lenb@kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI video: ignore BIOS initial backlight value for HP m4
Date: Tue, 12 Nov 2013 10:21:27 +0800	[thread overview]
Message-ID: <528190A7.1000107@intel.com> (raw)
In-Reply-To: <52818CD6.7000704@intel.com>

On 11/12/2013 10:05 AM, Aaron Lu wrote:
> On 05/28/2013 10:05 AM, Alex Hung wrote:
>> On HP m4 lapops, BIOS reports minimum backlight on boot and
>> causes backlight to dim completely. This ignores the initial backlight
>> values and set to max brightness.
>>
>> Buglink: https://bugs.launchpad.net/bugs/1184501
> 
> Same here, but since there is no acpidump attached, I'm not that sure.

Oh, I missed the attached acpi.log which is the dump.
So yes, it is the same problem. I think it should be safe to revert
these two patches, but for certain, I'll ask in launchpad the original
reporter to give it a test.

Thanks,
Aaron
 
>>
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>>  drivers/acpi/video.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
>> index 5b32e15..d0937ab 100644
>> --- a/drivers/acpi/video.c
>> +++ b/drivers/acpi/video.c
>> @@ -464,6 +464,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>>  		DMI_MATCH(DMI_PRODUCT_NAME, "HP 1000 Notebook PC"),
>>  		},
>>  	},
>> +	{
>> +	 .callback = video_ignore_initial_backlight,
>> +	 .ident = "HP Pavilion m4",
>> +	 .matches = {
>> +		DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
>> +		DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"),
>> +		},
>> +	},
>>  	{}
>>  };
>>  
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


      reply	other threads:[~2013-11-12  2:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28  2:05 [PATCH] ACPI video: ignore BIOS initial backlight value for HP m4 Alex Hung
2013-11-12  2:05 ` Aaron Lu
2013-11-12  2:21   ` Aaron Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528190A7.1000107@intel.com \
    --to=aaron.lu@intel.com \
    --cc=alex.hung@canonical.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).