From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH] ACPI video: ignore BIOS initial backlight value for HP m4 Date: Tue, 12 Nov 2013 10:21:27 +0800 Message-ID: <528190A7.1000107@intel.com> References: <1369706709-9189-1-git-send-email-alex.hung@canonical.com> <52818CD6.7000704@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:25160 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318Ab3KLCU5 (ORCPT ); Mon, 11 Nov 2013 21:20:57 -0500 In-Reply-To: <52818CD6.7000704@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alex Hung , rui.zhang@intel.com, lenb@kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org On 11/12/2013 10:05 AM, Aaron Lu wrote: > On 05/28/2013 10:05 AM, Alex Hung wrote: >> On HP m4 lapops, BIOS reports minimum backlight on boot and >> causes backlight to dim completely. This ignores the initial backlight >> values and set to max brightness. >> >> Buglink: https://bugs.launchpad.net/bugs/1184501 > > Same here, but since there is no acpidump attached, I'm not that sure. Oh, I missed the attached acpi.log which is the dump. So yes, it is the same problem. I think it should be safe to revert these two patches, but for certain, I'll ask in launchpad the original reporter to give it a test. Thanks, Aaron >> >> Signed-off-by: Alex Hung >> --- >> drivers/acpi/video.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c >> index 5b32e15..d0937ab 100644 >> --- a/drivers/acpi/video.c >> +++ b/drivers/acpi/video.c >> @@ -464,6 +464,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = { >> DMI_MATCH(DMI_PRODUCT_NAME, "HP 1000 Notebook PC"), >> }, >> }, >> + { >> + .callback = video_ignore_initial_backlight, >> + .ident = "HP Pavilion m4", >> + .matches = { >> + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"), >> + }, >> + }, >> {} >> }; >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >