From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH 01/12] ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode Date: Tue, 19 Nov 2013 15:32:57 +0800 Message-ID: <528B1429.6050403@linaro.org> References: <1384047382-20623-1-git-send-email-al.stone@linaro.org> <2429527.tRrfhbW41X@vostro.rjw.lan> <1431790.mopcNu4HUR@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:49812 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186Ab3KSHcI (ORCPT ); Tue, 19 Nov 2013 02:32:08 -0500 Received: by mail-pa0-f47.google.com with SMTP id kq14so3358422pab.6 for ; Mon, 18 Nov 2013 23:32:07 -0800 (PST) In-Reply-To: <1431790.mopcNu4HUR@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Al Stone , "linux-acpi@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Al Stone , Robert Moore +CC Robert Moore On 2013-11-18 21:37, Rafael J. Wysocki wrote: > On Monday, November 18, 2013 09:21:30 PM Hanjun Guo wrote: [...] >>>>>> Signed-off-by: Hanjun Guo >>>>>> Signed-off-by: Al Stone >>>>>> --- >>>>>> drivers/acpi/Kconfig | 8 ++++++++ >>>>>> include/acpi/platform/aclinux.h | 4 ++++ >>>>>> 2 files changed, 12 insertions(+) >>>>>> >>>>>> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >>>>>> index 589da05..7bbd3b0 100644 >>>>>> --- a/drivers/acpi/Kconfig >>>>>> +++ b/drivers/acpi/Kconfig >>>>>> @@ -354,6 +354,14 @@ config ACPI_BGRT >>>>>> data from the firmware boot splash. It will appear under >>>>>> /sys/firmware/acpi/bgrt/ . >>>>>> >>>>>> +config ACPI_REDUCED_HARDWARE >>>>>> + bool "Hardware-reduced ACPI support" >>>>>> + depends on !(IA64 || X86) >>>>> >>>>> Why don't you use >>>>> >>>>> depends on (ARM || ARM64) >>>>> >>>>> here instead? >>>>> >>>> >>>> hardware-reduced is not restricted to ARM platforms, that's why >>>> >>>> I used depends on !(IA64 || X86) here. >>> >>> So what exactly are the other platforms using ACPI in the Linux kernel? >>> >> >> To telling the truth, I didn't see any other platform using ACPI except >> IA64, X86 and ARM/ARM64, I just used depends on !(IA64 || x86) for >> future purpose. > > However, if you used "depends on ARM || ARM64" (the parens are not needed BTW), > the subsequent patches wouldn't need to check CONFIG_ARM/CONFIG_ARM64 in > addition to CONFIG_ACPI_REDUCED_HARDWARE. That would simplify stuff somewhat. Yes, you are right :) It is ok for me to use "depends on ARM || ARM64", but Robert Moore also suggested that hardware-reduced is not restricted to ARM platforms. Robert, any comments on this? Thanks Hanjun