From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Stone Subject: Re: [PATCH 11/12] ACPI: use of ACPI_FADT_32BIT_TIMER is not allowed in HW reduced mode Date: Wed, 20 Nov 2013 15:15:36 -0700 Message-ID: <528D3488.9080905@linaro.org> References: <1384047382-20623-1-git-send-email-al.stone@linaro.org> <1384047382-20623-12-git-send-email-al.stone@linaro.org> <1401228.IWQJyQWsXM@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f177.google.com ([209.85.223.177]:42318 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146Ab3KTWPh (ORCPT ); Wed, 20 Nov 2013 17:15:37 -0500 Received: by mail-ie0-f177.google.com with SMTP id tp5so7540786ieb.36 for ; Wed, 20 Nov 2013 14:15:37 -0800 (PST) In-Reply-To: <1401228.IWQJyQWsXM@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linaro-acpi@lists.linaro.org, Al Stone On 11/17/2013 03:26 PM, Rafael J. Wysocki wrote: > On Saturday, November 09, 2013 06:36:21 PM al.stone@linaro.org wrote: >> From: Al Stone > > I'm reading the patch as "the timer resolution in HW reduced mode is always > 32-bit". Is my reading correct? Whups, I see what I did. You are reading the patch correctly. However, what the code should ultimately do is ignore the ACPI_FADT_32BIT_TIMER flag completely. Let me look at where the timer_resolution field is being used also since it is not immediately clear what value it should have, or if it should even be used, when in reduced HW mode. >> Signed-off-by: Al Stone >> --- >> drivers/acpi/acpica/utxface.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/acpica/utxface.c b/drivers/acpi/acpica/utxface.c >> index be322c8..fe94b3e 100644 >> --- a/drivers/acpi/acpica/utxface.c >> +++ b/drivers/acpi/acpica/utxface.c >> @@ -187,7 +187,8 @@ acpi_status acpi_get_system_info(struct acpi_buffer * out_buffer) >> >> /* Timer resolution - 24 or 32 bits */ >> >> - if (acpi_gbl_FADT.flags & ACPI_FADT_32BIT_TIMER) { >> + if (!acpi_gbl_reduced_hardware && >> + (acpi_gbl_FADT.flags & ACPI_FADT_32BIT_TIMER)) { >> info_ptr->timer_resolution = 24; >> } else { >> info_ptr->timer_resolution = 32; >> -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org -----------------------------------