From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [RFC part2 PATCH 7/9] irqdomain: Add a new API irq_create_acpi_mapping() Date: Wed, 04 Dec 2013 23:38:56 +0800 Message-ID: <529F4C90.4070402@linaro.org> References: <1386088753-2850-1-git-send-email-hanjun.guo@linaro.org> <1386088753-2850-8-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pb0-f48.google.com ([209.85.160.48]:56415 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392Ab3LDPjK (ORCPT ); Wed, 4 Dec 2013 10:39:10 -0500 Received: by mail-pb0-f48.google.com with SMTP id md12so23471650pbc.7 for ; Wed, 04 Dec 2013 07:39:10 -0800 (PST) In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Rob Herring Cc: "Rafael J. Wysocki" , Catalin Marinas , Will Deacon , Russell King - ARM Linux , Daniel Lezcano , Mark Rutland , Matthew Garrett , "linaro-kernel@lists.linaro.org" , Linaro Patches , Olof Johansson , "linux-kernel@vger.kernel.org" , Rob Herring , linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org, Amit Daniel Kachhap , Grant Likely , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" On 2013=E5=B9=B412=E6=9C=8804=E6=97=A5 01:25, Rob Herring wrote: > On Tue, Dec 3, 2013 at 10:39 AM, Hanjun Guo w= rote: >> From: Amit Daniel Kachhap >> >> This patch introduces a new API for acpi based irq mapping. >> >> [hanjun: Rework this patch to delete the reference to >> gic_irq_domain_xlate() which can simplify the code a lot.] >> >> Signed-off-by: Amit Daniel Kachhap >> Signed-off-by: Hanjun Guo >> --- >> include/linux/acpi.h | 2 ++ >> kernel/irq/irqdomain.c | 27 +++++++++++++++++++++++++++ >> 2 files changed, 29 insertions(+) >> >> diff --git a/include/linux/acpi.h b/include/linux/acpi.h >> index 1e6a0ac..edd5806 100644 >> --- a/include/linux/acpi.h >> +++ b/include/linux/acpi.h >> @@ -141,6 +141,8 @@ int acpi_map_lsapic(acpi_handle handle, int phys= id, int *pcpu); >> int acpi_unmap_lsapic(int cpu); >> #endif /* CONFIG_ACPI_HOTPLUG_CPU */ >> >> +unsigned int irq_create_acpi_mapping(irq_hw_number_t hwirq, >> + unsigned int type); >> int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gs= i_base); >> int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base); >> void acpi_irq_stats_init(void); >> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >> index cf68bb3..c661552 100644 >> --- a/kernel/irq/irqdomain.c >> +++ b/kernel/irq/irqdomain.c >> @@ -501,6 +501,33 @@ unsigned int irq_create_of_mapping(struct of_ph= andle_args *irq_data) >> } >> EXPORT_SYMBOL_GPL(irq_create_of_mapping); >> >> +#ifdef CONFIG_ACPI >> +unsigned int irq_create_acpi_mapping(irq_hw_number_t hwirq, >> + unsigned int type) >> +{ >> + struct irq_domain *domain; >> + unsigned int virq; >> + >> + domain =3D irq_default_domain; >> + if (!domain) { >> + pr_warn("no irq domain found !\n"); >> + return 0; >> + } >> + >> + /* Create mapping */ >> + virq =3D irq_create_mapping(domain, hwirq); >> + if (!virq) >> + return virq; >> + >> + /* Set type if specified and different than the current one = */ >> + if (type !=3D IRQ_TYPE_NONE && >> + type !=3D irq_get_trigger_type(virq)) >> + irq_set_irq_type(virq, type); >> + return virq; >> +} >> +EXPORT_SYMBOL_GPL(irq_create_acpi_mapping); > There is nothing ACPI specific about this function. This is simply > irq_create_of_mapping w/o translating of_phandle_args to a hwirq and > type. So I expect the code to be re-factored here to mirror that. Sorry for my bad english, do you mean create a OF free function and call that from the OF function ? Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html