From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: Removal of EXPORT_SYMBOL(acpi_os_wait_events_complete) in 3.13
Date: Tue, 17 Dec 2013 17:59:20 +0100 [thread overview]
Message-ID: <52B082E8.8070009@intel.com> (raw)
In-Reply-To: <CA+5PVA7Kj0UAsGs6TzrMYYhPhOyMKzb3Qn9FHh8fMrLDTwToog@mail.gmail.com>
On 12/12/2013 9:50 PM, Josh Boyer wrote:
> Hi Rafael,
Hi,
> We had a user report[1] their nvidia driver failing to load on 3.13
> because acpi_os_wait_events_complete is no longer exported. They
> believe it was in error and I told them to contact you. Just in case
> they don't bother to do that,
Well, they haven't so far. :-)
> I thought I'd send you a quick email
> about it. The commit in question is:
>
> commit 7b98118aaa5d75644c48f41fc5d0cc181e478383
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date: Thu Nov 7 01:45:40 2013 +0100
>
> ACPI / hotplug: Consolidate deferred execution of ACPI hotplug routines
>
>
> and it doesn't mention anything about unexporting that symbol in the changelog.
It doesn't, but removing the export was intentional, because that export
is not needed for any in-the-tree modules any more.
In principle I can add the export back, but this function is supposed to
be an internal ACPI interface and the NVidia driver is abusing it quite
openly, so I'm not sure. I guess I'll just send a patch for broader
discussion.
Thanks,
Rafael
next parent reply other threads:[~2013-12-17 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+5PVA7Kj0UAsGs6TzrMYYhPhOyMKzb3Qn9FHh8fMrLDTwToog@mail.gmail.com>
2013-12-17 16:59 ` Rafael J. Wysocki [this message]
2013-12-17 17:07 ` Removal of EXPORT_SYMBOL(acpi_os_wait_events_complete) in 3.13 Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B082E8.8070009@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox