Re: [Patch v2 00/13] Introduce ACPI _DSM helper functions to simplify code

[Jiang Liu <jiang.liu@linux.intel.com>]

Thanks, Rafael!

On 2014/1/6 5:58, Rafael J. Wysocki wrote:
> On Thursday, December 19, 2013 08:38:09 PM Jiang Liu wrote:
>> There are several drivers making use of ACPI _DSM method to detect
>> and invoke device specific methods. Currently every driver has
>> implemented its private version to support ACPI _DSM method.
>> So this patch introduces three helper functions to support ACPI _DSM
>> method, which will be used to replace open-coded versions.  It helps
>> to simplify code and improve code readability.
>>
>> It also includes some bugfixes for TPM/nouveau drivers.
>>
>> It applies to the mainstream kernel on top of
>> b0031f2 Merge tag 's2mps11-build' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
>>
>> Due to lacking of hardware platform, I have only tested the ACPI _DSM
>> helper functions and TPM related changes, but haven't tested changes to
>> other drivers yet. So appreciate help to review and test these patches.
>>
>> V1->V2
>> 1) fix an issue in initializing acpi_object structure
>>
>> Jiang Liu (13):
>>   ACPI: introduce helper interfaces to support ACPI _DSM method
>>   ACPI, extlog: replace open-coded _DSM specific code with helper
>>     functions
>>   PCI, pci-label: release allocated ACPI object on error recovery path
>>   ACPI, PCI: replace open-coded _DSM specific code with helper
>>     functions
>>   PCI, pci-label: treat PCI label with index 0 as valid label
>>   ACPI, TPM: fix memory leak when walking ACPI namespace
>>   ACPI, TPM: matching node name instead of full path when searching for
>>     TPM device
>>   ACPI, TPM: replace open-coded _DSM specific code with helper
>>     functions
>>   ACPI, TPM: detecting PPI features by checking availability of _DSM
>>     functions
>>   ACPI, i2c-hid: replace open-coded _DSM specific code with helper
>>     functions
>>   ACPI, i915: replace open-coded _DSM specific code with helper
>>     functions
>>   nouveau: fix memory leak in ACPI _DSM related code
>>   ACPI, nouveau: replace open-coded _DSM specific code with helper
>>     functions
>>
>>  drivers/acpi/acpi_extlog.c                     |   61 +---
>>  drivers/acpi/utils.c                           |   98 ++++++
>>  drivers/char/tpm/tpm_ppi.c                     |  406 +++++++++---------------
>>  drivers/gpu/drm/i915/intel_acpi.c              |  144 ++-------
>>  drivers/gpu/drm/nouveau/core/subdev/mxm/base.c |   48 +--
>>  drivers/gpu/drm/nouveau/nouveau_acpi.c         |  134 +++-----
>>  drivers/hid/i2c-hid/i2c-hid.c                  |   26 +-
>>  drivers/pci/pci-label.c                        |  129 +++-----
>>  include/acpi/acpi_bus.h                        |   26 ++
>>  9 files changed, 406 insertions(+), 666 deletions(-)
> 
> I've queued up the entire series for 3.14, thanks a lot!
>