Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Aaron Lu]

On 01/09/2014 05:05 PM, joeyli wrote:
> 於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
>> Am 09.01.2014 08:06, schrieb joeyli:
>>> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
>>>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
>>>>> version released then look at maybe someone report issue again.
>>>>>
>>>>> Very appreciate for your patch.
>>>>>
>>>>> Joey Lee
>>>>>
>>>>
>>>> Hi Joey,
>>>>
>>>> i have access to this hardware for next two weeks. Theoretically this
>>>> kernel should have patches you was talking about:
>>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
>>>>
>>>> it works with video.use_native_backlight=1.
>>>>
>>>> If you need more testing, you have two weeks ;)
>>>>
>>>> -- 
>>>> Regards,
>>>> Oleksij
>>>>
>>>
>>> Thanks for your testing, then I think just use
>>> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
>>> quirk to acer-wmi driver.
>>
>> You mean editing grub and adding kernel option?
> 
> Good point!
> 
> Looks we need add Aspire E1-572 to the video_dmi_table in
> drivers/acpi/video.c, like:
> http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html
> 
> But this patch doesn't in mainline. 
> 
> Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
> maybe we can ping Aaron to direct add it.

Since it is shipped with Win8, I think the following patch should take
care of it:
[PATCH] ACPI / video: Use native backlight control interface by default
http://www.spinics.net/lists/linux-acpi/msg47755.html

Last time Daniel seems to agree to merge it for test purpose, but I
didn't see it get merged somewhere yet.

Thanks,
Aaron

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

於 一，2014-01-13 於 10:49 +0800，Aaron Lu 提到：
> On 01/09/2014 05:05 PM, joeyli wrote:
> > 於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
> >> Am 09.01.2014 08:06, schrieb joeyli:
> >>> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
> >>>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
> >>>>> version released then look at maybe someone report issue again.
> >>>>>
> >>>>> Very appreciate for your patch.
> >>>>>
> >>>>> Joey Lee
> >>>>>
> >>>>
> >>>> Hi Joey,
> >>>>
> >>>> i have access to this hardware for next two weeks. Theoretically this
> >>>> kernel should have patches you was talking about:
> >>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
> >>>>
> >>>> it works with video.use_native_backlight=1.
> >>>>
> >>>> If you need more testing, you have two weeks ;)
> >>>>
> >>>> -- 
> >>>> Regards,
> >>>> Oleksij
> >>>>
> >>>
> >>> Thanks for your testing, then I think just use
> >>> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
> >>> quirk to acer-wmi driver.
> >>
> >> You mean editing grub and adding kernel option?
> > 
> > Good point!
> > 
> > Looks we need add Aspire E1-572 to the video_dmi_table in
> > drivers/acpi/video.c, like:
> > http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html
> > 
> > But this patch doesn't in mainline. 
> > 
> > Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
> > maybe we can ping Aaron to direct add it.
> 
> Since it is shipped with Win8, I think the following patch should take
> care of it:
> [PATCH] ACPI / video: Use native backlight control interface by default
> http://www.spinics.net/lists/linux-acpi/msg47755.html
> 
> Last time Daniel seems to agree to merge it for test purpose, but I
> didn't see it get merged somewhere yet.
> 
> Thanks,
> Aaron
> 

Will we removed all video_set_use_native_backlight devices in
video_dmi_table quirk table after the above patch merged?

Just wonder what is our strategy of those issue machines? Add to quirk
table or will enable native backlight control by default?


Thanks a lot!
Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Aaron Lu]

On 01/13/2014 03:05 PM, joeyli wrote:
> 於 一，2014-01-13 於 10:49 +0800，Aaron Lu 提到：
>> On 01/09/2014 05:05 PM, joeyli wrote:
>>> 於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
>>>> Am 09.01.2014 08:06, schrieb joeyli:
>>>>> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
>>>>>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
>>>>>>> version released then look at maybe someone report issue again.
>>>>>>>
>>>>>>> Very appreciate for your patch.
>>>>>>>
>>>>>>> Joey Lee
>>>>>>>
>>>>>>
>>>>>> Hi Joey,
>>>>>>
>>>>>> i have access to this hardware for next two weeks. Theoretically this
>>>>>> kernel should have patches you was talking about:
>>>>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
>>>>>>
>>>>>> it works with video.use_native_backlight=1.
>>>>>>
>>>>>> If you need more testing, you have two weeks ;)
>>>>>>
>>>>>> -- 
>>>>>> Regards,
>>>>>> Oleksij
>>>>>>
>>>>>
>>>>> Thanks for your testing, then I think just use
>>>>> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
>>>>> quirk to acer-wmi driver.
>>>>
>>>> You mean editing grub and adding kernel option?
>>>
>>> Good point!
>>>
>>> Looks we need add Aspire E1-572 to the video_dmi_table in
>>> drivers/acpi/video.c, like:
>>> http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html
>>>
>>> But this patch doesn't in mainline. 
>>>
>>> Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
>>> maybe we can ping Aaron to direct add it.
>>
>> Since it is shipped with Win8, I think the following patch should take
>> care of it:
>> [PATCH] ACPI / video: Use native backlight control interface by default
>> http://www.spinics.net/lists/linux-acpi/msg47755.html
>>
>> Last time Daniel seems to agree to merge it for test purpose, but I
>> didn't see it get merged somewhere yet.
>>
>> Thanks,
>> Aaron
>>
> 
> Will we removed all video_set_use_native_backlight devices in
> video_dmi_table quirk table after the above patch merged?
> 
> Just wonder what is our strategy of those issue machines? Add to quirk
> table or will enable native backlight control by default?

For Win8 laptops, perhaps enable native backlight control by default.

Thanks,
Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html