linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Igor Gnatenko <i.gnatenko.brain@gmail.com>, linux-acpi@vger.kernel.org
Cc: "James Hogan" <james@albanarts.com>,
	"Mike Galbraith" <bitbucket@online.de>,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	dri-devel@lists.freedesktop.org,
	platform-driver-x86@vger.kernel.org,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Matthew Garrett" <matthew.garrett@nebula.com>,
	"Kalle Valo" <kvalo@adurom.com>,
	"Yves-Alexis Perez" <corsac@debian.org>,
	"Martin Steigerwald" <Martin@lichtvoll.de>,
	"Lee Chun-Yi" <joeyli.kernel@gmail.com>,
	"Ben Jencks" <ben@bjencks.net>, "Jörg Otte" <jrg.otte@gmail.com>,
	intel-gfx@lists.freedesktop.org,
	"Kevin Smith" <thirdwiggin@gmail.com>,
	"Peter Weber" <bugs@ttyhoney.com>,
	"Joerg Platte" <jplatte@naasa.net>,
	"Seth Forshee" <seth.forshee@canonical.com>,
	"Lennart Poettering" <lennart@poettering.net>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Theodore Tso" <tytso@mit.edu>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.ke
Subject: Re: [PATCH v3] ACPI / video: Add systems that should favor native backlight interface
Date: Mon, 20 Jan 2014 16:12:37 +0800	[thread overview]
Message-ID: <52DCDA75.2000108@intel.com> (raw)
In-Reply-To: <1390053249-18919-1-git-send-email-i.gnatenko.brain@gmail.com>

Hi Igor,

On 01/18/2014 09:54 PM, Igor Gnatenko wrote:
> From: Aaron Lu <aaron.lu@intel.com>
> 
> Some system's ACPI video backlight control interface is broken and the
> native backlight control interface should be used by default. This patch
> sets the use_native_backlight parameter to true for those systems so
> that video backlight control interface will not be created. To be
> specific, the ThinkPad T430s/X230/X1 Carbon, Lenovo Yoga 13, Dell
> Inspiron 7520, Acer Aspire 5733Z and HP ProBook 4340s are added here,
> if they appear in some other DMI table before, they are removed from there.
> 
> Note that the user specified kernel cmdline option will always have the
> highest priority, i.e. if use_native_backlight=0 is specified and the
> system is in the DMI table, the video module will not skip registering
> backlight interface for it.
> 
> Thinkpad T430s:
> Reported-by: Theodore Tso <tytso@mit.edu>
> Reported-and-tested-by: Peter Weber <bugs@ttyhoney.com>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231
> Thinkpad X230:
> Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231
> ThinkPad X1 Carbon:
> Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
> Lenovo Yoga 13:
> Reported-by: Lennart Poettering <lennart@poettering.net>
> Reported-and-tested-by: Kevin Smith <thirdwiggin@gmail.com>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=63811
> Dell Inspiron 7520:
> Reported-by: Rinat Ibragimov <ibragimovrinat@mail.ru>
> Acer Aspire 5733Z:
> Reported-by: <sov.info@mail.ru>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=62941
> HP ProBook 4340s:
> Reported-and-tested-by: Vladimir Sherenkov <a_12300@mail.ru>
> Reference: http://redmine.russianfedora.pro/issues/1258
> 
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>

Thanks for updating this patch.

In the meantime, I plan to make some small modifications to this patch
in next revision:
1 remove the win8 OSI check, I've seen win7 laptops that also needs to
  have only the GPU interface left and checking win8 doesn't make much
  sense now;
2 add more entries for laptops that appeared in bugzilla recently.

  reply	other threads:[~2014-01-20  8:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 13:54 [PATCH v3] ACPI / video: Add systems that should favor native backlight interface Igor Gnatenko
2014-01-20  8:12 ` Aaron Lu [this message]
2014-01-20 13:34   ` Matthew Garrett
2014-01-21  2:24     ` Aaron Lu
2014-01-21  3:17       ` Matthew Garrett
2014-01-21  5:32         ` Aaron Lu
2014-01-21 12:11           ` Matthew Garrett
2014-01-22  1:58             ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DCDA75.2000108@intel.com \
    --to=aaron.lu@intel.com \
    --cc=Martin@lichtvoll.de \
    --cc=ben@bjencks.net \
    --cc=bitbucket@online.de \
    --cc=bugs@ttyhoney.com \
    --cc=corsac@debian.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felipe.contreras@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=i.gnatenko.brain@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=james@albanarts.com \
    --cc=joeyli.kernel@gmail.com \
    --cc=jplatte@naasa.net \
    --cc=jrg.otte@gmail.com \
    --cc=kvalo@adurom.com \
    --cc=lennart@poettering.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.ke \
    --cc=matthew.garrett@nebula.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=seth.forshee@canonical.com \
    --cc=thirdwiggin@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).