From: Aaron Lu <aaron.lu@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Pavel Machek <pavel@suse.cz>, Len Brown <lenb@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lan Tianyu <tianyu.lan@intel.com>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>
Subject: Re: Why we put FAN to full speed in its suspend callback
Date: Thu, 23 Jan 2014 09:08:42 +0800 [thread overview]
Message-ID: <52E06B9A.5080905@intel.com> (raw)
In-Reply-To: <3635936.Umz7ZeDeIX@vostro.rjw.lan>
Removed Konstantin since his email address is undeliverable.
On 01/23/2014 05:11 AM, Rafael J. Wysocki wrote:
> On Wednesday, January 22, 2014 05:04:54 PM Aaron Lu wrote:
>> Hi,
>
> Hi,
>
>> I was trying to minimize system suspend time and it turned out there are
>> firmwares that would do crazy things like delaying 10ms in FAN's power on
>> control method. So I wonder why do we want to put the FAN into ACPI D0
>> state when we are going to enter a sleep state? The code seems to be
>> written according to Pavel's comment here:
>> https://bugzilla.kernel.org/show_bug.cgi?id=5000#c6
>> It would be great to understand why and remove that operation if
>> possible, thanks for reading and taking your time bringing back your
>> ancient memory :-)
>
> Yes, this is for image creation code during hibernation and the same set of
> callbacks was used for hibernation and suspend at that time. I think we can
> remove that thing for system suspend and leave it for hibernation only.
OK, thanks a lot for the clarification, I'll prepare a patch to do that.
prev parent reply other threads:[~2014-01-23 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 9:04 Why we put FAN to full speed in its suspend callback Aaron Lu
2014-01-22 21:11 ` Rafael J. Wysocki
2014-01-23 1:08 ` Aaron Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E06B9A.5080905@intel.com \
--to=aaron.lu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox