From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [Linaro-acpi] [PATCH v4 5/5] ACPI: Replace printk with pr_* in tables.c Date: Wed, 19 Feb 2014 16:32:34 +0000 Message-ID: <5304DCA2.5080906@arm.com> References: <1392731700-10992-1-git-send-email-hanjun.guo@linaro.org> <1392731700-10992-6-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:34225 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753731AbaBSQcL convert rfc822-to-8bit (ORCPT ); Wed, 19 Feb 2014 11:32:11 -0500 In-Reply-To: <1392731700-10992-6-git-send-email-hanjun.guo@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo , "Rafael J. Wysocki" Cc: Sudeep.Holla@arm.com, Lan Tianyu , "linaro-acpi@lists.linaro.org" , "patches@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On 18/02/14 13:55, Hanjun Guo wrote: > This patch just do some clean up to replace printk with pr_*, > no functional change. > Any particular reason for choosing just this file in this series ? It seems but off-topic in this series. The printk format is same in almost all other acpi files and it's better to change all or none for consistency. > Signed-off-by: Hanjun Guo > --- > drivers/acpi/tables.c | 51 +++++++++++++++++++------------------------------ > 1 file changed, 20 insertions(+), 31 deletions(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index 5837f85..97bc6df 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -55,8 +55,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) > { > struct acpi_madt_local_apic *p = > (struct acpi_madt_local_apic *)header; > - printk(KERN_INFO PREFIX > - "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", > + pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", You can even get rid of PREFIX by defining pr_fmt instead. If the intention is to move to pr_* format it's better to have this as separate patch and convert all of them. Based on the grep patterns, regex should to helpful to find and replace them all :) Regards, Sudeep