From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yan, Zheng" Subject: Re: Info: mapping multiple BARs. Your kernel is fine. Date: Thu, 20 Mar 2014 16:16:54 +0800 Message-ID: <532AA3F6.9090402@intel.com> References: <20140224162400.GE16457@pd.tnic> <4205942.Tp8ltEsv6e@vostro.rjw.lan> <532A514C.5010106@intel.com> <744357E9AAD1214791ACBA4B0B9092630121F201@SHSMSX101.ccr.corp.intel.com> <744357E9AAD1214791ACBA4B0B9092630121F3B7@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <744357E9AAD1214791ACBA4B0B9092630121F3B7@SHSMSX101.ccr.corp.intel.com> Sender: linux-pci-owner@vger.kernel.org To: "Zhang, Rui" , Stephane Eranian Cc: "Lu, Aaron" , "Rafael J. Wysocki" , Borislav Petkov , lkml , "x86@kernel.org" , Bjorn Helgaas , Linux PCI , ACPI Devel Maling List , Yinghai Lu , "H. Peter Anvin" List-Id: linux-acpi@vger.kernel.org On 03/20/2014 03:53 PM, Zhang, Rui wrote: > The resource length is also hardcoded to 0x6000, right? > This is probably a problem, because > only if the resource length read from PCI config space is larger than 0x4000, > drivers/pnp/quirks.c will detect the conflict and disable the PNP0C02 > resource 0xfed10000 - 0xfed13fff, and the PCI device can request this > resource successfully. > In order to check this, can you please attach the dmesg output after boot? maybe the issue can be fixed by below untested patch --- diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c index fd5e883..2b3d834 100644 --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c @@ -1701,7 +1701,7 @@ static struct uncore_event_desc snb_uncore_imc_events[] = { #define SNB_UNCORE_PCI_IMC_BAR_OFFSET 0x48 /* page size multiple covering all config regs */ -#define SNB_UNCORE_PCI_IMC_MAP_SIZE 0x6000 +#define SNB_UNCORE_PCI_IMC_MAP_SIZE 0x8 #define SNB_UNCORE_PCI_IMC_DATA_READS 0x1 #define SNB_UNCORE_PCI_IMC_DATA_READS_BASE 0x5050 @@ -1736,7 +1736,8 @@ static void snb_uncore_imc_init_box(struct intel_uncore_box *box) addr &= ~(PAGE_SIZE - 1); - box->io_addr = ioremap(addr, SNB_UNCORE_PCI_IMC_MAP_SIZE); + box->io_addr = ioremap(addr + SNB_UNCORE_PCI_IMC_CTR_BASE, + SNB_UNCORE_PCI_IMC_MAP_SIZE); box->hrtimer_duration = UNCORE_SNB_IMC_HRTIMER_INTERVAL; } @@ -1832,7 +1833,7 @@ static int snb_uncore_imc_event_init(struct perf_event *event) } /* must be done before validate_group */ - event->hw.event_base = base; + event->hw.event_base = base - SNB_UNCORE_PCI_IMC_CTR_BASE; event->hw.config = cfg; event->hw.idx = idx;