From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
To: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
linux-acpi@vger.kernel.org, rjw@rjwysocki.net,
Len Brown <lenb@kernel.org>
Subject: Re: [Linaro-acpi] [RFC] ACPI: Add new function to get table entries
Date: Thu, 20 Mar 2014 15:06:14 +0100 [thread overview]
Message-ID: <532AF5D6.3060406@linaro.org> (raw)
In-Reply-To: <CAJ5Y-eZCB=gZp2vvfY11y4-fxqRbwA4o2m2TAEPNZ_x-+hgwig@mail.gmail.com>
On 20.03.2014 14:53, Ashwin Chaugule wrote:
> On 20 March 2014 09:48, Tomasz Nowicki <tomasz.nowicki@linaro.org> wrote:
>
>>>
>>> Although I generally agree that mapping/umapping should be done in the
>>> caller, it seems umapping in this manner is baked in APCI core code
>>> and I didn't want to change too many things at once without causing
>>> unintentional side effects elsewhere.
>>
>>
>> You will not cause any side effects if unmapping will stay in
>> acpi_table_parse_entries().
>
> What if callers only call acpi_parse_entries()?
acpi_parse_entries() requires already mapped MADT table and as you
agreed on caller mapping/unmapping responsibility, caller need to unmap
MADT table after all. I mean sth like that:
1. Get MADT table pointer
2. Map MADT table
3. Use acpi_parse_entries() as many times as you wish (some calls can
return error but you don't have to map MADT again)
4. Unmap MADT table
What do you think?
Tomasz
prev parent reply other threads:[~2014-03-20 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 23:09 [RFC] ACPI: Add new function to get table entries Ashwin Chaugule
2014-03-20 8:25 ` [Linaro-acpi] " Hanjun Guo
2014-03-20 13:17 ` Ashwin Chaugule
2014-03-20 10:05 ` Tomasz Nowicki
2014-03-20 10:16 ` Tomasz Nowicki
2014-03-20 13:27 ` Ashwin Chaugule
2014-03-20 14:06 ` Tomasz Nowicki
2014-03-20 14:39 ` Ashwin Chaugule
2014-03-20 14:59 ` Tomasz Nowicki
2014-03-20 13:25 ` Ashwin Chaugule
2014-03-20 13:48 ` Tomasz Nowicki
2014-03-20 13:53 ` Ashwin Chaugule
2014-03-20 14:06 ` Tomasz Nowicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AF5D6.3060406@linaro.org \
--to=tomasz.nowicki@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox