[PATCH] acpi-video: Revert native brightness quirk for ThinkPad T530

[PATCH] acpi-video: Revert native brightness quirk for ThinkPad T530

[Hans de Goede]

Seems it helps some users, but causes issues for other users:
https://bugzilla.redhat.com/show_bug.cgi?id=1089545

So lets drop it for now until we've figured out a better fix.

Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/acpi/video.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 0fec70d..8309100 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -516,14 +516,6 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
 	},
 	{
 	 .callback = video_set_use_native_backlight,
-	 .ident = "ThinkPad T530",
-	 .matches = {
-		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T530"),
-		},
-	},
-	{
-	 .callback = video_set_use_native_backlight,
 	 .ident = "ThinkPad W530",
 	 .matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-- 
1.9.0

Re: [PATCH] acpi-video: Revert native brightness quirk for ThinkPad T530

[Rafael J. Wysocki]

On Friday, May 16, 2014 09:10:41 PM Hans de Goede wrote:
> Seems it helps some users, but causes issues for other users:
> https://bugzilla.redhat.com/show_bug.cgi?id=1089545
> 
> So lets drop it for now until we've figured out a better fix.

So you hadn't even waited for all of your users to have a chance to test the
blacklist patch and you asked me to push it for -rc5 nevertheless.  You don't
even realize how disappointing that is.

I had to rebase this patch, so it has to go through autobuild testing and
I'll try to add it to my -rc6 pull request, but I'm not going to take any new
blacklist entries for anything later than -rc4 in the future.  And don't even
*try* to argue with that.

> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/acpi/video.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 0fec70d..8309100 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -516,14 +516,6 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  	},
>  	{
>  	 .callback = video_set_use_native_backlight,
> -	 .ident = "ThinkPad T530",
> -	 .matches = {
> -		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> -		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T530"),
> -		},
> -	},
> -	{
> -	 .callback = video_set_use_native_backlight,
>  	 .ident = "ThinkPad W530",
>  	 .matches = {
>  		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH] acpi-video: Revert native brightness quirk for ThinkPad T530

[Hans de Goede]

Hi,

On 05/16/2014 10:50 PM, Rafael J. Wysocki wrote:
> On Friday, May 16, 2014 09:10:41 PM Hans de Goede wrote:
>> Seems it helps some users, but causes issues for other users:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1089545
>>
>> So lets drop it for now until we've figured out a better fix.
> 
> So you hadn't even waited for all of your users to have a chance to test the
> blacklist patch and you asked me to push it for -rc5 nevertheless.  You don't
> even realize how disappointing that is.

That is not how it happened, after the patch going out a new user with a T530
showed up, who did not have any problems before so never was part of the bug
reports about this before, but got problems after the patch.
So it seems that different T530's behave differently.

This may have something todo with whether they were booted in EFI mode or not,
or maybe there are just 2 different revisions out there.

Note that this is all not in vain:

1) We would have never heard from that user without the patch
2) The behavior the patch causes is going to be the default in 3.16, so now we've
caught it early and can work on a fix before 3.16-rc1.

> I had to rebase this patch, so it has to go through autobuild testing and
> I'll try to add it to my -rc6 pull request, but I'm not going to take any new
> blacklist entries for anything later than -rc4 in the future.  And don't even
> *try* to argue with that.

I can see that being reasonable, although I believe this time it does actually work
in out advantage, esp. with the default behavior change planned for 3.15.

Regards,

Hans


> 
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>  drivers/acpi/video.c | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
>> index 0fec70d..8309100 100644
>> --- a/drivers/acpi/video.c
>> +++ b/drivers/acpi/video.c
>> @@ -516,14 +516,6 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>>  	},
>>  	{
>>  	 .callback = video_set_use_native_backlight,
>> -	 .ident = "ThinkPad T530",
>> -	 .matches = {
>> -		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> -		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T530"),
>> -		},
>> -	},
>> -	{
>> -	 .callback = video_set_use_native_backlight,
>>  	 .ident = "ThinkPad W530",
>>  	 .matches = {
>>  		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>
>