public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Lewis Toohey <lewis@toohey.co.uk>, Hans de Goede <hdegoede@redhat.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: Bug Report - [Acer Aspire V5-122P] Unable to adjust screen brightness
Date: Mon, 26 May 2014 13:48:54 +0800	[thread overview]
Message-ID: <5382D5C6.5080001@intel.com> (raw)
In-Reply-To: <CADNzsyMCnbNu6CbWfV73CM99Qs=Lw22Q8pSQ23O31sopNDpaig@mail.gmail.com>

On 05/26/2014 04:42 AM, Lewis Toohey wrote:
> On 23 May 2014 13:50, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi Lewis et all,
>>
>> On 05/23/2014 02:07 PM, Lewis Toohey wrote:
>>> On 23 May 2014 02:34, Aaron Lu <aaron.lu@intel.com> wrote:
>>>> On 05/21/2014 09:02 PM, Lewis Toohey wrote:
>>>>> Hi Aaron
>>>>>
>>>>> I followed your instructions and can report some limited success. I
>>>>> have two interfaces listed in /sys/class/backlight namely:
>>>>>   acpi_video0  radeon_bl0
>>>>>
>>>>> max_brightness for acpi_video0 is 11. Echo-ing new values to
>>>>> brightness appears to have no effect.
>>>>>
>>>>> max_brightness for radeon_bl0 is 255. Echo-ing new values to
>>>>> brightness does adjust the screen brightness as you would expect.
>>>>>
>>>>> Results are the same on both battery and powered.
>>>>>
>>>>> I hope that is useful.
>>>>
>>>> I think Hans' patchset should solve your problem, can you please give it
>>>> a try? You will need to pass the video.use_native_backlight=1 to kernel
>>>> cmdline when testing, thanks.
>>>>
>>>> [PATCH resend 0/4] Make video.use_native_backlight=1 work properly with nouveau
>>>> http://www.spinics.net/lists/dri-devel/msg59941.html
>>>>
>>>> -Aaron
>>>
>>> Aaron
>>>
>>> Thank you for this. Unfortunately I am going to have to ask you for a
>>> bit of help here as I am now, officially, "out of my depth". I
>>> appreciate this is a pain as you will have to take time explaining it
>>> to me and I apologise for that.
>>>
>>> I have figured out how to pass the kernel command line argument, this
>>> is not an issue.
>>>
>>> I have located the patch you refer to here:
>>> https://bugzilla.redhat.com/attachment.cgi?id=894577
>>> (which I believe is correct) but I cannot figure out how to apply it.
>>
>> That is not the right patch, you need a set of 2 patches. I've attached
>> them to this mail. Note please ignore the numbering starting at 6, these
>> are the 2 patches you need. You will need to build a Linux kernel with
>> these 2 patches applied, see your distributions documentation on how
>> to build a kernel from source.
>>
>> I don't know which distro you are using, I've a Fedora kernel with this
>> patches included available here:
>>
>> http://people.fedoraproject.org/~jwrdegoede/rhbz1093171/
>>
>> Regards,
>>
>> Hans
> 
> Hans
> 
> Unfortunately I am unable to apply these patches against the latest
> mainline kernel. I get two fails when applying the second patch file
> and then the kernel will not compile. Please see output information
> below.

I've prepared a git branch for you:
https://github.com/aaronlu/linux.git for-lewis

It's based on Rafael's linux-next plus Hans' patch 2 and 3.

Thanks,
Aaron

> 
> Can you advise?
> 
> Many thanks
> 
> ===APPLYING PATCHES TO LATEST MAINLINE KERNEL====
> 
> lewis@HappyFunMeaowMeaow:~/KernelTesting/Kernel/linux$ patch -p1 <
> 0006-backlight-Add-backlight-device-un-registration-notif.patch
> (Stripping trailing CRs from patch; use --binary to disable.)
> patching file drivers/video/backlight/backlight.c
> (Stripping trailing CRs from patch; use --binary to disable.)
> patching file include/linux/backlight.h
> lewis@HappyFunMeaowMeaow:~/KernelTesting/Kernel/linux$ patch -p1 <
> 0007-acpi-video-Unregister-the-backlight-device-if-a-raw-.patch
> (Stripping trailing CRs from patch; use --binary to disable.)
> patching file drivers/acpi/video.c
> Hunk #1 FAILED at 151.
> Hunk #2 succeeded at 161 (offset -1 lines).
> Hunk #3 FAILED at 1837.
> Hunk #4 succeeded at 1868 (offset -113 lines).
> Hunk #5 succeeded at 1999 (offset -113 lines).
> Hunk #6 succeeded at 2023 (offset -113 lines).
> 2 out of 6 hunks FAILED -- saving rejects to file drivers/acpi/video.c.rej
> 
> 
> ==LAST LINES OF BUILD BEFORE FAIL===
> 
>   CC [M]  fs/xfs/xfs_ioctl32.o
>   LD [M]  fs/xfs/xfs.o
> make[1]: Leaving directory `/home/lewis/KernelTesting/Kernel/linux'
> make: *** [debian/stamp/build/kernel] Error 2
> lewis@HappyFunMeaowMeaow:~/KernelTesting/Kernel/linux$
> 
> 


  reply	other threads:[~2014-05-26  5:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 18:32 Bug Report - [Acer Aspire V5-122P] Unable to adjust screen brightness Lewis Toohey
2014-05-21  1:21 ` Aaron Lu
2014-05-21  7:05   ` Lewis Toohey
2014-05-21 12:36     ` Aaron Lu
2014-05-21 13:02       ` Lewis Toohey
2014-05-23  1:34         ` Aaron Lu
2014-05-23 12:07           ` Lewis Toohey
2014-05-23 12:50             ` Hans de Goede
2014-05-23 13:38               ` Lewis Toohey
2014-05-24 11:23               ` Lewis Toohey
2014-05-25 20:42               ` Lewis Toohey
2014-05-26  5:48                 ` Aaron Lu [this message]
2014-05-26 12:18                   ` Lewis Toohey
2014-05-26 19:09                     ` Lewis Toohey
2014-05-27  1:12                       ` Aaron Lu
2014-05-30 13:12                         ` Lewis Toohey
2014-06-03  1:22                           ` Aaron Lu
2014-06-09  7:38                             ` Lewis Toohey
2014-06-10  5:33                               ` Sluggish performance after resume//Re: " Aaron Lu
2014-06-10 16:58                                 ` Ben Widawsky
2014-06-10 19:59                                   ` Lewis Toohey
2014-06-10 22:54                                     ` Ben Widawsky
2014-06-11  7:03                                       ` Aaron Lu
2014-06-11  7:41                                         ` Lewis Toohey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5382D5C6.5080001@intel.com \
    --to=aaron.lu@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=lewis@toohey.co.uk \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox