From: Markus Elfring <Markus.Elfring@web.de>
To: Zhe Qiao <qiaozhe@iscas.ac.cn>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sunil V L <sunilvl@ventanamicro.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2] ACPI: PCI: Release excess memory usage
Date: Tue, 29 Apr 2025 17:56:21 +0200 [thread overview]
Message-ID: <538f8456-1b28-4e7b-83ae-71b4c4ebcf8b@web.de> (raw)
In-Reply-To: <20250429091051.249911-1-qiaozhe@iscas.ac.cn>
…
> +++ b/drivers/pci/pci-acpi.c
> @@ -1677,15 +1677,12 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
>
> root_ops = kzalloc(sizeof(*root_ops), GFP_KERNEL);
> if (!root_ops) {
> - kfree(ri);
> - return NULL;
> + goto free_ri;
> }
Would you like to omit curly brackets around a single statement?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.15-rc4#n197
Regards,
Markus
prev parent reply other threads:[~2025-04-29 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 9:10 [PATCH v2] ACPI: PCI: Release excess memory usage Zhe Qiao
2025-04-29 13:20 ` Jonathan Cameron
2025-04-29 15:46 ` Markus Elfring
2025-04-29 15:56 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538f8456-1b28-4e7b-83ae-71b4c4ebcf8b@web.de \
--to=markus.elfring@web.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiaozhe@iscas.ac.cn \
--cc=rafael@kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox