public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Aaron Lu <aaron.lu@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Julian Wollrath <jwollrath@web.de>, linux-acpi@vger.kernel.org
Subject: Re: [Regression]: Changing brightness does not work with v3.16-rc4
Date: Wed, 16 Jul 2014 10:35:33 +0200	[thread overview]
Message-ID: <53C63955.2090905@redhat.com> (raw)
In-Reply-To: <53C63431.7020205@redhat.com>

Hi,

On 07/16/2014 10:13 AM, Hans de Goede wrote:

<snip>

> I realize that this does not fix Julian's problem. As I see it there are
> 2 separate problems here:
> 
> 1) backlight control issues on Windows 8 laptops, this is what we are
> trying to solve with video.use_native_backlight=1 (and without using
> any acpi_osi override)
> 
> 2) Some component in the stack needs to responds to backlight key-presses
> and actually use the backlight control to change the backlight setting,
> normally this is done by gnome / kde / unity / xfce, but what about users
> not running those? For some of those users brightness_switch_enabled=1
> has been making things work for them, but that only works if acpi-video
> controls the backlight, which it does not do everywhere, and which we
> want to get away from for Windows 8 laptops since it is just too broken
> there.
> 
> Note that 2. is not limited to Windows 8 laptops / acpi-video in any
> way, we've 23 non acpi-video backlight drivers under drivers/platform/x86/
> alone + the native gpu backlight drivers. So what we really need is a
> solution for any laptop not using acpi-video for backlight control and
> not running one of the big 4 desktop environments.
> 
> Note that we pretty much have the same problem for any acpi event,
> power button pressed, lid closed, etc. are all "key press" type
> events typically handles by the desktop enviroment (e.g. we don't
> automatically suspend on lid-close, we just tell userspace). And we already
> have a solution for these type of events when running a desktop environment
> which handles them, these get handled by acpid. So to me it seems that

s/handles/does not handle/  small but important typo.

> the obvious (and one and only right) way to fix this is to teach acpid
> to deal with brightness key-presses.
> 
> I'm willing to write a patch for acpid to implement this, and then
> Julian's setup should just work without needing any special kernel
> commandline options.
> 
> Julian would that be an acceptable solution for you, and would you be
> willing to test such a patch ?

Regards,

Hans


  parent reply	other threads:[~2014-07-16  8:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 16:06 [Regression]: Changing brightness does not work with v3.16-rc4 Julian Wollrath
2014-07-12 16:24 ` Julian Wollrath
2014-07-14 18:21   ` Rafael J. Wysocki
2014-07-14 18:34     ` Julian Wollrath
2014-07-14 19:02       ` Rafael J. Wysocki
2014-07-14 19:10         ` Rafael J. Wysocki
2014-07-14 18:56           ` Julian Wollrath
2014-07-14 19:17             ` Rafael J. Wysocki
2014-07-15  6:06               ` Aaron Lu
2014-07-15 12:27                 ` Rafael J. Wysocki
2014-07-15 14:00                   ` Aaron Lu
2014-07-15 14:05                   ` Hans de Goede
2014-07-15 14:45                     ` Aaron Lu
2014-07-16  0:43                       ` Rafael J. Wysocki
2014-07-16  6:29                         ` Hans de Goede
2014-07-16  7:19                           ` Aaron Lu
2014-07-16  8:13                             ` Hans de Goede
2014-07-16  8:30                               ` Aaron Lu
2014-07-16  8:35                               ` Hans de Goede [this message]
2014-07-16 11:50                                 ` Julian Wollrath
2014-07-16 11:52                                   ` Hans de Goede
2014-07-15 21:38                 ` Julian Wollrath
2014-07-16  2:36             ` Aaron Lu
2014-07-16 11:36               ` Julian Wollrath
2014-07-14  2:06 ` Aaron Lu
2014-07-14 12:42   ` Julian Wollrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C63955.2090905@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=aaron.lu@intel.com \
    --cc=jwollrath@web.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox