From: Martin Kepplinger <martink@posteo.de>
To: Hugh Dickins <hughd@google.com>
Cc: daniel.vetter@ffwll.ch, Zhang Rui <rui.zhang@intel.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] rc1 rc2 rc3 not bootable - black screen after kernel loading
Date: Fri, 25 Jul 2014 12:15:41 +0200 [thread overview]
Message-ID: <53D22E4D.2060600@posteo.de> (raw)
In-Reply-To: <alpine.LSU.2.11.1407241610320.3733@eggly.anvils>
Am 2014-07-25 01:20, schrieb Hugh Dickins:
> On Thu, 24 Jul 2014, Martin Kepplinger wrote:
>> Am 2014-06-30 12:39, schrieb Martin Kepplinger:
>>> back to aaeb2554337217dfa4eac2fcc90da7be540b9a73 as the first bad
>>> commit. why is this not revertable exactly? how can I show a complete
>>> list of commits this merge introduces?
>>>
>>
>> It seems that _nobody_ is running a simple 32 bit i915 (acer) laptop.
>> rc6 is still unusable. Black screen directly after kernel-loading. no
>> change since rc1.
>>
>> Seems like I won't be able to use 3.16. I'm happy to test patches and am
>> happy for any advice what to do, when time permits.
>
> Martin, I know nothing about aaeb25543372 and why it should be relevant,
> but if you're having rc1..rc6 32-bit i915 black screens, please try this
> patch that Daniel Vetter put in his fixes queue on Monday, which I'm
> hoping will reach Linus for -rc7.
>
> Hugh
>
> [PATCH] drm/i915: fix freeze with blank screen booting highmem
>
> x86_64 boots and displays fine, but booting x86_32 with CONFIG_HIGHMEM
> has frozen with a blank screen throughout 3.16-rc on this ThinkPad T420s,
> with i915 generation 6 graphics.
>
> Fix 9d0a6fa6c5e6 ("drm/i915: add render state initialization"): kunmap()
> takes struct page * argument, not virtual address. Which the compiler
> kindly points out, if you use the appropriate u32 *batch, instead of
> silencing it with a void *.
>
> Why did bisection lead decisively to nearby 229b0489aa75 ("drm/i915:
> add null render states for gen6, gen7 and gen8")? Because the u32
> deposited at that virtual address by the previous stub failed the
> PageHighMem test, and so caused no harm.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>
> drivers/gpu/drm/i915/i915_gem_render_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- 3.16-rc/drivers/gpu/drm/i915/i915_gem_render_state.c 2014-06-16 00:28:52.384076465 -0700
> +++ linux/drivers/gpu/drm/i915/i915_gem_render_state.c 2014-07-21 20:10:03.824481521 -0700
> @@ -31,7 +31,7 @@
> struct i915_render_state {
> struct drm_i915_gem_object *obj;
> unsigned long ggtt_offset;
> - void *batch;
> + u32 *batch;
> u32 size;
> u32 len;
> };
> @@ -80,7 +80,7 @@ free:
>
> static void render_state_free(struct i915_render_state *so)
> {
> - kunmap(so->batch);
> + kunmap(kmap_to_page(so->batch));
> i915_gem_object_ggtt_unpin(so->obj);
> drm_gem_object_unreference(&so->obj->base);
> kfree(so);
>
yes! thanks Hugh. On top of linus' current tree, that finally fixes my
problem! I hope it'll be included soon!
martin
p.s. linux-media removed from thread
next prev parent reply other threads:[~2014-07-25 10:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 14:24 [BUG] rc1 and rc2: Laptop unusable: on boot,screen black instead of native resolution Martin Kepplinger
2014-06-23 1:10 ` Zhang, Rui
2014-06-23 12:22 ` Martin Kepplinger
2014-06-23 13:14 ` Zhang Rui
2014-06-23 14:46 ` Martin Kepplinger
2014-06-27 15:14 ` Zhang Rui
2014-06-27 18:09 ` Martin Kepplinger
2014-06-27 19:51 ` Martin Kepplinger
2014-06-27 22:14 ` Martin Kepplinger
2014-06-30 7:52 ` [BUG] rc3 Oops: unable to handle kernel NULL pointer dereference at 0000074c Martin Kepplinger
2014-06-30 8:18 ` Zhang Rui
2014-06-30 8:20 ` Zhang Rui
2014-06-30 9:00 ` Martin Kepplinger
2014-06-30 10:39 ` [BUG] rc1 rc2 rc3 not bootable - black screen after kernel loading Martin Kepplinger
2014-07-24 16:18 ` Martin Kepplinger
2014-07-24 22:26 ` Woody Suwalski
2014-07-24 23:20 ` Hugh Dickins
2014-07-25 10:15 ` Martin Kepplinger [this message]
2014-07-26 23:19 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D22E4D.2060600@posteo.de \
--to=martink@posteo.de \
--cc=daniel.vetter@ffwll.ch \
--cc=hughd@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).