From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH 03/19] ARM64 / ACPI: Introduce lowlevel suspend function Date: Fri, 25 Jul 2014 18:42:15 +0800 Message-ID: <53D23487.6090703@linaro.org> References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-4-git-send-email-hanjun.guo@linaro.org> <20140724153406.GC26190@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140724153406.GC26190@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Rutland Cc: Mark Brown , Catalin Marinas , Will Deacon , Lv Zheng , Lorenzo Pieralisi , Daniel Lezcano , Robert Moore , "linux-acpi@vger.kernel.org" , "grant.likely@linaro.org" , Charles Garcia-Tobin , Robert Richter , Jason Cooper , Arnd Bergmann , Marc Zyngier , Liviu Dudau , "linaro-acpi-private@linaro.org" , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" , "graeme.gregory@linaro.org" , Randy Dunlap List-Id: linux-acpi@vger.kernel.org On 2014-7-24 23:34, Mark Rutland wrote: [...] >> early_param("acpi", parse_acpi); >> + >> +/* >> + * acpi_suspend_lowlevel() - save kernel state and suspend. >> + * >> + * TBD when ARM/ARM64 starts to support suspend... >> + */ >> +int (*acpi_suspend_lowlevel)(void); > > Shouldn't this should be intialised to NULL explicitly? Yes, as ARM64 does not support suspend, initialize it to NULL will be fine, will update in next version. Thanks Hanjun