From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [Bugfix] x86, irq: Fix bug in setting IOAPIC pin attributes Date: Tue, 26 Aug 2014 11:55:18 -0700 Message-ID: <53FCD816.6070108@infradead.org> References: <20140822124145.GF1660@lahna.fi.intel.com> <1409042706-11958-1-git-send-email-jiang.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:44272 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753317AbaHZSz6 (ORCPT ); Tue, 26 Aug 2014 14:55:58 -0400 In-Reply-To: <1409042706-11958-1-git-send-email-jiang.liu@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jiang Liu , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Yinghai Lu , Borislav Petkov , Grant Likely , x86@kernel.org, Prarit Bhargava Cc: Konrad Rzeszutek Wilk , Andrew Morton , Tony Luck , Joerg Roedel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar On 08/26/14 01:45, Jiang Liu wrote: > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > index 29290f554e79..66c2700c9f83 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -3896,7 +3896,15 @@ int mp_irqdomain_map(struct irq_domain *domain, unsigned int virq, > + /* > + * setup_IO_APIC_irqs() programs all legacy IRQs with default > + * trigger and polarity attirbutes. Don't set the flag for that attributes. > + * case so the first legacy IRQ user could reprogram the pin > + * with real trigger and polarity attributes. > + */ thanks, -- ~Randy