From: Russell Haley <yumpusamongus@gmail.com>
To: Mario Limonciello <superm1@kernel.org>,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Perry Yuan <perry.yuan@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "Rafael J . Wysocki" <rafael@kernel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list:CPU FREQUENCY SCALING FRAMEWORK"
<linux-pm@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v3 10/11] cpufreq: amd-pstate: Add documentation for `amd_pstate_hw_prefcore`
Date: Tue, 10 Sep 2024 05:19:20 -0500 [thread overview]
Message-ID: <53f402cb-1a0d-4b48-b92a-e968ea77a138@gmail.com> (raw)
In-Reply-To: <20240905163007.1350840-11-superm1@kernel.org>
On 9/5/24 11:30 AM, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> Explain that the sysfs file represents both preferred core being
> enabled by the user and supported by the hardware.
>
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v2->v3:
> * Add tag
> ---
> Documentation/admin-guide/pm/amd-pstate.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index e13915c540648..d5c050ea390dc 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -263,6 +263,11 @@ lowest non-linear performance in `AMD CPPC Performance Capability
> <perf_cap_>`_.)
> This attribute is read-only.
>
> +``amd_pstate_hw_prefcore``
> +
> +Whether the platform supports the preferred core feature and it has been
> +enabled. This attribute is read-only.
> +
> ``energy_performance_available_preferences``
>
> A list of all the supported EPP preferences that could be used for
I notice I am confused. If the attribute is read only, how can it be
enabled by the user?
next prev parent reply other threads:[~2024-09-10 10:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 16:29 [PATCH v3 00/11] Adjustments for preferred core detection Mario Limonciello
2024-09-05 16:29 ` [PATCH v3 01/11] x86/amd: Move amd_get_highest_perf() from amd.c to cppc.c Mario Limonciello
2024-09-05 16:29 ` [PATCH v3 02/11] ACPI: CPPC: Adjust return code for inline functions in !CONFIG_ACPI_CPPC_LIB Mario Limonciello
2024-09-05 16:29 ` [PATCH v3 03/11] x86/amd: Rename amd_get_highest_perf() to amd_get_boost_ratio_numerator() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 04/11] ACPI: CPPC: Drop check for non zero perf ratio Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 05/11] ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 06/11] x86/amd: Move amd_get_highest_perf() out of amd-pstate Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 07/11] x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 08/11] cpufreq: amd-pstate: Merge amd_pstate_highest_perf_set() into amd_get_boost_ratio_numerator() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 09/11] cpufreq: amd-pstate: Optimize amd_pstate_update_limits() Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 10/11] cpufreq: amd-pstate: Add documentation for `amd_pstate_hw_prefcore` Mario Limonciello
2024-09-10 10:19 ` Russell Haley [this message]
2024-09-10 16:36 ` Mario Limonciello
2024-09-05 16:30 ` [PATCH v3 11/11] amd-pstate: Add missing documentation for `amd_pstate_prefcore_ranking` Mario Limonciello
2024-10-16 22:03 ` [PATCH v3 00/11] Adjustments for preferred core detection Ivan Shapovalov
2024-10-16 22:06 ` Mario Limonciello
2024-10-16 22:19 ` Ivan Shapovalov
2024-10-17 0:18 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f402cb-1a0d-4b48-b92a-e968ea77a138@gmail.com \
--to=yumpusamongus@gmail.com \
--cc=bp@alien8.de \
--cc=gautham.shenoy@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=superm1@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox