From: Arnd Bergmann <arnd@arndb.de>
To: Dongdong Liu <liudongdong3@huawei.com>
Cc: helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com,
tn@semihalf.com, wangzhou1@hisilicon.com,
pratyush.anand@gmail.com, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
jcm@redhat.com, gabriele.paoloni@huawei.com,
charles.chenxin@huawei.com, hanjun.guo@linaro.org,
linuxarm@huawei.com
Subject: Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers
Date: Wed, 31 Aug 2016 13:48:16 +0200 [thread overview]
Message-ID: <5406169.iVLlEcSJ8X@wuerfel> (raw)
In-Reply-To: <1472644094-82731-4-git-send-email-liudongdong3@huawei.com>
On Wednesday, August 31, 2016 7:48:14 PM CEST Dongdong Liu wrote:
> +static struct hisi_rc_res rc_res[] = {
> + {
> + HIP05,
> + {
> + DEFINE_RES_MEM(0xb0070000, SZ_4K),
> + DEFINE_RES_MEM(0xb0080000, SZ_4K),
> + DEFINE_RES_MEM(0xb0090000, SZ_4K),
> + DEFINE_RES_MEM(0xb00a0000, SZ_4K)
> + }
> + },
> + {
> + HIP06,
> + {
> + DEFINE_RES_MEM(0xa0090000, SZ_4K),
> + DEFINE_RES_MEM(0xa0200000, SZ_4K),
> + DEFINE_RES_MEM(0xa00a0000, SZ_4K),
> + DEFINE_RES_MEM(0xa00b0000, SZ_4K)
> + }
> + },
> + {
> + HIP07,
> + {
> + DEFINE_RES_MEM(0xa0090000, SZ_4K),
> + DEFINE_RES_MEM(0xa0200000, SZ_4K),
> + DEFINE_RES_MEM(0xa00a0000, SZ_4K),
> + DEFINE_RES_MEM(0xa00b0000, SZ_4K),
> + DEFINE_RES_MEM(0x8a0090000UL, SZ_4K),
> + DEFINE_RES_MEM(0x8a0200000UL, SZ_4K),
> + DEFINE_RES_MEM(0x8a00a0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x8a00b0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a0090000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a0200000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a00a0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x600a00b0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a0090000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a0200000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a00a0000UL, SZ_4K),
> + DEFINE_RES_MEM(0x700a00b0000UL, SZ_4K)
> + }
> + },
I don't know much about ACPI, but I'm pretty sure this is not
the normal way to find MMIO resources. Why not read them from
the ACPI tables?
Arnd
next prev parent reply other threads:[~2016-08-31 11:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 11:48 [RFC PATCH V2 0/3] Add ACPI support for Hisilicon PCIe Host Controller Dongdong Liu
2016-08-31 11:48 ` [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI Dongdong Liu
2016-08-31 11:45 ` Arnd Bergmann
2016-09-01 2:05 ` Dongdong Liu
2016-09-01 7:41 ` Arnd Bergmann
2016-09-01 12:44 ` Dongdong Liu
2016-09-01 14:02 ` Arnd Bergmann
2016-09-02 2:02 ` Dongdong Liu
2016-09-20 9:45 ` Gabriele Paoloni
2016-09-20 13:22 ` Arnd Bergmann
2016-08-31 11:48 ` [RFC PATCH V2 2/3] PCI: hisi: Add ECAM support for devices that are not RC Dongdong Liu
2016-08-31 11:48 ` [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Dongdong Liu
2016-08-31 11:48 ` Arnd Bergmann [this message]
2016-09-01 2:16 ` Dongdong Liu
2016-08-31 22:56 ` Rafael J. Wysocki
2016-09-01 3:23 ` Dongdong Liu
2016-09-01 23:38 ` Rafael J. Wysocki
2016-09-02 3:49 ` Dongdong Liu
-- strict thread matches above, loose matches on Subject: below --
2016-02-08 12:41 [RFC PATCH v2 0/3] Add ACPI support for HiSilicon PCIe " Gabriele Paoloni
2016-02-08 12:41 ` [RFC PATCH v2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs " Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5406169.iVLlEcSJ8X@wuerfel \
--to=arnd@arndb.de \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=charles.chenxin@huawei.com \
--cc=gabriele.paoloni@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jcm@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=pratyush.anand@gmail.com \
--cc=rafael@kernel.org \
--cc=tn@semihalf.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox