linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	ntrrgc@gmail.com,
	ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI / video: update the condition to check if a device is in _DOD list
Date: Sun, 30 Nov 2014 09:14:29 +0800	[thread overview]
Message-ID: <547A6F75.6050806@intel.com> (raw)
In-Reply-To: <20141129173447.GA3608@norris-Latitude-E6410>

On 11/30/2014 01:34 AM, Brian Norris wrote:
> Tested-by: Brian Norris <computersforpeace@gmail.com>

Thanks for the test! Updated patch with changelog:

>From 0b11bb529245ddceb69eb558477b9b4a81208f4b Mon Sep 17 00:00:00 2001
From: Aaron Lu <aaron.lu@intel.com>
Date: Sun, 30 Nov 2014 09:01:15 +0800
Subject: [PATCH] ACPI / video: update the condition to check if a device is in _DOD list

Commit 0b8db271f159 ("ACPI / video: check _DOD list when creating
backlight devices") checks if the video device is in the bind devices
list to decide if we should create backlight device for it, that causes
problem for one Dell Latitude E6410, where none of the video output
devices are properly bound due to the way how we did the comparing
between its _ADR and the _DOD's values. Solve this problem by comparing
the lower 12 bits of both the device's _ADR and the _DOD's values instead
of relying on bind result.

Fixes: 0b8db271f159 ("ACPI / video: check _DOD list when creating backlight devices")
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Tested-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/acpi/video.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 41e6b977ceb2..185a57d13723 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -1164,7 +1164,8 @@ static bool acpi_video_device_in_dod(struct acpi_video_device *device)
 		return true;
 
 	for (i = 0; i < video->attached_count; i++) {
-		if (video->attached_array[i].bind_info == device)
+		if ((video->attached_array[i].value.int_val & 0xfff) ==
+		    (device->device_id & 0xfff))
 			return true;
 	}
 
-- 
1.9.3


  reply	other threads:[~2014-11-30  1:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30  6:10 [PATCH] ACPI / video: check _DOD list when creating backlight device Aaron Lu
2014-09-30 20:18 ` Rafael J. Wysocki
2014-10-09  8:27   ` Aaron Lu
2014-11-28  9:59     ` Brian Norris
2014-11-28 11:55       ` Aaron Lu
2014-11-28 17:18         ` Brian Norris
2014-11-29 13:01           ` Aaron Lu
2014-11-29 17:34             ` Brian Norris
2014-11-30  1:14               ` Aaron Lu [this message]
2014-12-03  2:25                 ` [PATCH] ACPI / video: update the condition to check if a device is in _DOD list Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547A6F75.6050806@intel.com \
    --to=aaron.lu@intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntrrgc@gmail.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).