From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [V2 PATCH 0/2] Introduce ACPI support for ahci_platform driver Date: Wed, 7 Jan 2015 15:40:02 -0600 Message-ID: <54ADA7B2.8000205@amd.com> References: <1420492275-6878-1-git-send-email-Suravee.Suthikulpanit@amd.com> <2457489.S2ztcy2W3i@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-by2on0113.outbound.protection.outlook.com ([207.46.100.113]:51232 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753382AbbAGVkV (ORCPT ); Wed, 7 Jan 2015 16:40:21 -0500 In-Reply-To: <2457489.S2ztcy2W3i@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: lenb@kernel.org, hdegoede@redhat.com, tj@kernel.org, arnd@arndb.de, mjg59@srcf.ucam.org, grant.likely@linaro.org, hanjun.guo@linaro.org, al.stone@linaro.org, graeme.gregory@linaro.org, leo.duran@amd.com, linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org On 1/5/2015 5:24 PM, Rafael J. Wysocki wrote: > On Monday, January 05, 2015 03:11:13 PM Suravee Suthikulpanit wrote: >> This patch series introduce ACPI support for non-PCI AHCI platform driver. >> Existing ACPI support for AHCI assumes the device controller is a PCI device. >> >> Also, since there is no ACPI _HID/_CID for generic AHCI controller, the driver >> could not use them for matching devices. Therefore, this patch introduces >> a mechanism for drivers to match devices using ACPI _CLS method. >> >> This patch series is rebased from and tested with: >> >> http://git.linaro.org/leg/acpi/acpi.git acpi-5.1-v7 >> >> This topic was discussed earlier here (as part of introducing support for >> AMD Seattle SATA controller): >> >> http://marc.info/?l=linux-arm-kernel&m=141083492521584&w=2 >> >> NOTE: >> * PATCH 2/2 has already been Acked-by Tejun Heo in V1. I only made >> a minor renaming of the acpi_cls to acpi_match_cls for clarity >> in V2. It probably should be routed together with the PATCH 1/2 >> (once acked) since it defines the new member in the struct. >> >> Changes V1 (https://lkml.org/lkml/2014/12/19/345) >> * Rebased to 3.19.0-rc2 >> * Change from acpi_cls in device_driver to acpi_match_cls (Hanjun comment) >> * Change the matching logic in acpi_driver_match_device() due to the new >> special PRP0001 _HID. >> * Simplify the return type of acpi_match_device_cls() to boolean. >> >> Changes from RFC (https://lkml.org/lkml/2014/12/17/446) >> * Remove #ifdef and make non-ACPI version of the acpi_match_device_cls >> as inline. (per Arnd) >> * Simplify logic to retrieve and evaluate _CLS handle. (per Hanjun) >> >> Suravee Suthikulpanit (2): >> ACPI / scan: Add support for ACPI _CLS device matching >> ata: ahci_platform: Add ACPI _CLS matching >> >> drivers/acpi/scan.c | 79 +++++++++++++++++++++++++++++++++++++++-- >> drivers/ata/Kconfig | 2 +- >> drivers/ata/ahci_platform.c | 3 ++ >> include/acpi/acnames.h | 1 + >> include/linux/acpi.h | 10 ++++++ >> include/linux/device.h | 1 + >> include/linux/mod_devicetable.h | 6 ++++ >> 7 files changed, 98 insertions(+), 4 deletions(-) > > I'll take care of this when I'm back from travels later this month. Thanks! > Thanks Rafael. Suravee