From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Langsdorf Subject: Re: [PATCH v7 01/17] arm64: allow late use of early_ioremap Date: Thu, 15 Jan 2015 12:44:34 -0600 Message-ID: <54B80A92.6050209@redhat.com> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-2-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbbAOSqD (ORCPT ); Thu, 15 Jan 2015 13:46:03 -0500 In-Reply-To: <1421247905-3749-2-git-send-email-hanjun.guo@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , Arnd Bergmann , Mark Rutland , Grant Likely , Will Deacon Cc: Lorenzo Pieralisi , Graeme Gregory , Sudeep Holla , Jon Masters , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Mark Brown , Rob Herring , Robert Richter , Randy Dunlap , Charles.Garcia-Tobin@arm.com, phoenix.liyi@huawei.com, Timur Tabi , suravee.suthikulpanit@amd.com, wangyijing@huawei.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Mark Salter , Leif Lindholm , Ard Biesheuvel On 01/14/2015 09:04 AM, Hanjun Guo wrote: > From: Mark Salter > > Commit 0e63ea48b4d8 (arm64/efi: add missing call to early_ioremap_reset()) > added a missing call to early_ioremap_reset(). This triggers a BUG if code > tries using early_ioremap() after the early_ioremap_reset(). This is a > problem for some ACPI code which needs short-lived temporary mappings > after paging_init() but before acpi_early_init() in start_kernel(). This > patch adds definitions for the __late_set_fixmap() and __late_clear_fixmap() > which avoids the BUG by allowing later use of early_ioremap(). > > Signed-off-by: Mark Salter > CC: Leif Lindholm > CC: Ard Biesheuvel > [hj: update the change log] > Signed-off-by: Hanjun Guo > --- Tested-by: Mark Langsdorf