From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Nowicki Subject: Re: [PATCH v4 7/9] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver. Date: Thu, 12 Mar 2015 14:42:51 +0100 Message-ID: <550197DB.7030900@linaro.org> References: <1426083169-8698-1-git-send-email-tomasz.nowicki@linaro.org> <1426083169-8698-8-git-send-email-tomasz.nowicki@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Brian Gerst Cc: bhelgaas@google.com, wangyijing@huawei.com, arnd@arndb.de, hanjun.guo@linaro.org, Liviu.Dudau@arm.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , rjw@rjwysocki.net, al.stone@linaro.org, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , the arch/x86 maintainers , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linaro-acpi@lists.linaro.org List-Id: linux-acpi@vger.kernel.org On 11.03.2015 17:30, Brian Gerst wrote: > On Wed, Mar 11, 2015 at 10:12 AM, Tomasz Nowicki > wrote: > >> diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile >> index 5c6fc35..35c765b 100644 >> --- a/arch/x86/pci/Makefile >> +++ b/arch/x86/pci/Makefile >> @@ -1,7 +1,10 @@ >> obj-y := i386.o init.o >> >> obj-$(CONFIG_PCI_BIOS) += pcbios.o >> -obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o >> +obj-$(CONFIG_PCI_MMCONFIG) += direct.o mmconfig-shared.o >> +ifeq ($(BITS),32) >> +obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_32.o >> +endif >> obj-$(CONFIG_PCI_DIRECT) += direct.o >> obj-$(CONFIG_PCI_OLPC) += olpc.o >> obj-$(CONFIG_PCI_XEN) += xen.o > > This would be better written as: > > mmconfig-y := direct.o mmconfig-shared.o > mmconfig-$(CONFIG_X86_32) += mmconfig_32.o > obj-$(CONFIG_PCI_MMCONFIG) += $(mmconfig-y) Nice! Will update my patch. Tomasz