public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Stepan Bujnak <stepanbujnak@fastmail.fm>
Cc: be.0@gmx.com, linux-acpi <linux-acpi@vger.kernel.org>
Subject: Backlight control broken on Lenovo Ideapad Z570
Date: Wed, 18 Mar 2015 14:12:06 +0100	[thread overview]
Message-ID: <550979A6.20306@redhat.com> (raw)

Hi Stepan,

I'm mailing you because you are the author of:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a11d342f

I've been debugging the same problem together with a Fedora user:
https://bugzilla.redhat.com/show_bug.cgi?id=1187004

And for him your fix does not work, before your fix landed we already
came to the conclusion that to fix this we need to disable both the
acpi_video backlight interface as well as the ideapad-laptop interface.

Your patch only disables the acpi_video backlight interface (and as
a side effect actually enables the ideapad-laptop interface).

I assume that you've a working backlight setup on your Lenovo Ideapad Z570,
can you please do:

ls /sys/class/backlight

And let us know which interfaces show up there. Either you do have a working
ideapad_laptop interface, or you only get intel_backlight and for some reason
ideapad_laptop is not loading on your system (not enabled in your kernel config,
or blacklisted?).

If you only have intel_backlight then that explains why things are not working
for Be (the author of the Fedora bugreport), if you do have an ideapad_laptop
interface and that does work for you, then it seems that not all
Lenovo Ideapad Z570-s are created equal. In that case can you please blacklist
the ideapad-laptop module, reboot and see if things still work for you when
using intel_backlight to control the backlight? Once we've a confirmation
that either you are already using intel_backlight, or that intel_backlight also
works on your Ideapad, then I'll write a patch to replace yours which leaves
only intel_backlight even if the ideapad-laptop driver gets loaded.

Thanks & Regards,

Hans

             reply	other threads:[~2015-03-18 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 13:12 Hans de Goede [this message]
     [not found] ` <1426714264.2313054.242229237.35BDA633@webmail.messagingengine.com>
2015-03-18 21:40   ` Backlight control broken on Lenovo Ideapad Z570 Be
2015-03-19 12:50   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550979A6.20306@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=be.0@gmx.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=stepanbujnak@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox