From: Mario Limonciello <mario_limonciello@dell.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Matt Fleming <matt@codeblueprint.co.uk>
Cc: Jason Ekstrand <jason@jlekstrand.net>,
LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Bard Liao <bardliao@realtek.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [PATCH] ACPI: Adjust the return value of _REV on x86
Date: Tue, 24 Mar 2015 15:21:17 -0500 [thread overview]
Message-ID: <5511C73D.5020006@dell.com> (raw)
In-Reply-To: <3241492.O6brgYIrX9@vostro.rjw.lan>
On 03/24/2015 03:02 PM, Rafael J. Wysocki wrote:
> On Tuesday, March 24, 2015 03:24:12 PM Matt Fleming wrote:
> While I agree in general, one comment.
>
> We haven't decided about the patch yet. We may decide to bump up the _REV
> to 6 when ACPI 6 is out instead.
I'd be happy with this too.
> That said the whole using of _REV to special case Linux is broken by design
> and should be stopped immediately. Especially when it is done by comparing
> the return value of _REV to a specific number (like 5 or 3).
>
> Rafael
>
Yes, it's been made clear to me that this shouldn't be used in the future. I've shared that feedback to my BIOS architecture team.
next prev parent reply other threads:[~2015-03-24 20:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 8:50 [PATCH] ACPI: Adjust the return value of _REV on x86 Matthew Garrett
2015-03-16 20:34 ` Al Stone
2015-03-16 21:01 ` Matthew Garrett
[not found] ` <1426363131-14530-1-git-send-email-jason.ekstrand@intel.com>
[not found] ` <CAOFGe95CiLcHtzD3Vv-KJoCXfeHCyGa55OBkzHSZMWwdOyLnfg@mail.gmail.com>
2015-03-23 12:04 ` Matt Fleming
2015-03-24 5:50 ` Mario Limonciello
2015-03-24 9:17 ` Liam Girdwood
2015-03-24 14:41 ` Mario Limonciello
2015-03-24 15:24 ` Matt Fleming
2015-03-24 17:22 ` Mario Limonciello
2015-03-24 18:01 ` Matthew Garrett
2015-03-24 19:53 ` Mario Limonciello
2015-03-24 20:00 ` Matthew Garrett
2015-03-24 20:02 ` Rafael J. Wysocki
2015-03-24 20:21 ` Mario Limonciello [this message]
2015-03-26 2:40 ` Yuhong Bao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511C73D.5020006@dell.com \
--to=mario_limonciello@dell.com \
--cc=bardliao@realtek.com \
--cc=jason@jlekstrand.net \
--cc=lenb@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).