From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH 2/5] ARM64: kernel: psci: factor out probe function Date: Wed, 25 Mar 2015 21:29:49 +0800 Message-ID: <5512B84D.4090705@huawei.com> References: <1427219940-27201-1-git-send-email-lorenzo.pieralisi@arm.com> <1427219940-27201-3-git-send-email-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from szxga03-in.huawei.com ([119.145.14.66]:27022 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbbCYNka (ORCPT ); Wed, 25 Mar 2015 09:40:30 -0400 In-Reply-To: <1427219940-27201-3-git-send-email-lorenzo.pieralisi@arm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Mark Rutland , Catalin Marinas , Will Deacon , Hanjun Guo , Sudeep Holla On 2015/3/25 1:58, Lorenzo Pieralisi wrote: > PSCI v0.2+ versions provide a specific PSCI call (PSCI_VERSION) to > detect the PSCI version at run-time. Current PSCI v0.2 init code > carries out the version probing in the PSCI 0.2 DT init function, > but the version probing does not depend on DT so it can be factored out > in order to make it available to other boot mechanisms (ie ACPI) to > reuse. The psci_probe() probing function can be easily extended > to add detection and initialization of PSCI functions defined in > PSCI versions >0.2. > > Signed-off-by: Lorenzo Pieralisi > Cc: Hanjun Guo > Cc: Sudeep Holla > Cc: Mark Rutland > --- This cleanup looks pretty fine to me, Reviewed-by: Hanjun Guo Thanks Hanjun