From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH 03/11] irqchip / GIC: Add GIC version support in ACPI MADT Date: Thu, 21 May 2015 23:04:56 +0800 Message-ID: <555DF418.6050307@linaro.org> References: <1431953961-22706-1-git-send-email-hanjun.guo@linaro.org> <1431953961-22706-4-git-send-email-hanjun.guo@linaro.org> <555DE98A.2000909@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:36461 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754043AbbEUPFJ (ORCPT ); Thu, 21 May 2015 11:05:09 -0400 Received: by pabts4 with SMTP id ts4so108124529pab.3 for ; Thu, 21 May 2015 08:05:09 -0700 (PDT) In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thomas Gleixner Cc: Marc Zyngier , Jason Cooper , Will Deacon , Catalin Marinas , "Rafael J. Wysocki" , Jiang Liu , Lorenzo Pieralisi , Arnd Bergmann , Tomasz Nowicki , Grant Likely , Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org On 2015=E5=B9=B405=E6=9C=8821=E6=97=A5 22:39, Thomas Gleixner wrote: > On Thu, 21 May 2015, Hanjun Guo wrote: >> On 2015=E5=B9=B405=E6=9C=8821=E6=97=A5 04:02, Thomas Gleixner wrote: >>> On Mon, 18 May 2015, Hanjun Guo wrote: >>>> diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c >>>> index 65d6b93..855ead9 100644 >>>> --- a/drivers/acpi/irq.c >>>> +++ b/drivers/acpi/irq.c >>>> @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) >>>> if (acpi_disabled) >>>> return; >>>> >>>> + if (acpi_gic_version_init()) >>>> + return; >>> >>> This looks just wrong. acpi_irqchip_init() is a generic ACPI functi= on >>> and now you stick a GIC specific callback into it? >> >> For now, acpi_irqchip_init() just introduced for GIC init, not for >> APIC init for x86, and I don't see the usage in the near future. >> >>> >>> What calls acpi_irqchip_init? >> >> I renamed it as acpi_irq_init() in the later patch, which >> is called in irqchip_init() in drivers/irqchip/irqchip.c >> to init irqchip when DT is not available. > > Neither of those names is a good choice as they suggest that this is = a > generic acpi mechanism while in fact it is a GIC specific ACPI > extension. And its therefor wrong to put that code into drivers/acpi. OK, thanks for the suggestion. > > It belongs into drivers/irqchip/gic-acpi.c or some other descriptive > name. I already introduced a similar file named irq-gic-acpi.c under drivers/irqchip/, will move the code to there in next version. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html