Re: [Linux-nvdimm] [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development

Jeff Moyer
2015-05-15T20:25:39Z

Dan Williams <dan.j.williams@intel.com> writes:

> +config NFIT_TEST
> + tristate "NFIT TEST: Manufactured NFIT for interface testing"
> + depends on DMA_CMA
> + depends on LIBND=m
> + depends on ND_ACPI
> + depends on m
> + help
> + For development purposes register a manufactured
> + NFIT table to verify the resulting device model topology.
> + Note, this module arranges for ioremap_cache() to be
> + overridden locally to allow simulation of system-memory as an
> + io-memory-resource.
> +
> + Note, this test expects to be able to find at least 256MB of
> + CMA space (CONFIG_CMA_SIZE_MBYTES, cma=) or it will fail to
> + load.
> +
> + Say N unless you are doing development of the 'nd' subsystem.
> +

Too many TLAs. I'm guessing CMA means Conventional Memory Area to you.
To me it means contiguous memory allocator. Anyway, please define
acronyms when you use them, especially in help text. The help text also
doesn't really explain where it will find this memory. Would it be
possible to provide more direction there?

I don't have any useful commentary on the patch itself. I do wonder if
you shouldn't move this to the end, as it's hardly an integral part of
the patch set.

Cheers,
Jeff