From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH 10/11] irqchip / GICv2 / ACPI: Consolidate GICv2 ACPI related init code Date: Wed, 10 Jun 2015 17:29:47 +0100 Message-ID: <557865FB.1010502@arm.com> References: <1431953961-22706-1-git-send-email-hanjun.guo@linaro.org> <1431953961-22706-11-git-send-email-hanjun.guo@linaro.org> <555CF23B.1000002@linaro.org> <555DEB6A.8090404@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from foss.arm.com ([217.140.101.70]:54386 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965184AbbFJQ3v (ORCPT ); Wed, 10 Jun 2015 12:29:51 -0400 In-Reply-To: <555DEB6A.8090404@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hanjun Guo , Tomasz Nowicki , Jason Cooper , Will Deacon , Catalin Marinas , "Rafael J. Wysocki" Cc: Jiang Liu , Lorenzo Pieralisi , Arnd Bergmann , "grant.likely@linaro.org" , Thomas Gleixner , Olof Johansson , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" On 21/05/15 15:27, Hanjun Guo wrote: > On 2015=E5=B9=B405=E6=9C=8821=E6=97=A5 04:44, Tomasz Nowicki wrote: >> Hi Hanjun, >> >> On 05/18/2015 02:59 PM, Hanjun Guo wrote: >>> Move GICv2 ACPI related init code in irq-gic.c to irq-gic-acpi.c, >>> this can make the ACPI related GIC init code slef-contained. >>> >>> Introduce set_acpi_core_irqdomain() to set acpi_irqdomain then >>> it will be no need to make gic_data[] as a global value, and >>> it will save the confilcts with GICv3's gic_data in the later >>> patch. >>> >>> acpi_gic_parse_distributor() have the same function as >>> gic_acpi_parse_madt_distributor() to get the GIC distributor >>> physical base address, so just remove the duplicate one, and >>> only get the GIC version when it is unknown. >>> >>> Signed-off-by: Hanjun Guo >>> --- >>> drivers/irqchip/irq-gic-acpi.c | 95 >>> +++++++++++++++++++++++++++++++- >>> drivers/irqchip/irq-gic.c | 103 >>> +---------------------------------- >>> include/linux/irqchip/arm-gic-acpi.h | 5 ++ >>> 3 files changed, 101 insertions(+), 102 deletions(-) >>> >>> diff --git a/drivers/irqchip/irq-gic-acpi.c >>> b/drivers/irqchip/irq-gic-acpi.c >>> index 1388d9e..8463e48 100644 >>> --- a/drivers/irqchip/irq-gic-acpi.c >>> +++ b/drivers/irqchip/irq-gic-acpi.c >>> @@ -13,12 +13,16 @@ >>> >>> #include >>> #include >>> +#include >>> #include >>> #include >> >> arm-gic.h and arm-gic-v3.h describe register map for respective driv= ers >> and should be used separately within parent driver only. >=20 > Seems that there is no duplicate macros in that two head > file, but yes, it will confuse people. >=20 > Consolidating all ACPI GIC code is an improvement to make > ACPI related code self-contained, but also have some drawbacks, >=20 > Marc, what do you think? What I think is "Over my dead body". These include files are private to the respective interrupt controller code, and the only reason they are in linux/irqchip is because the corresponding KVM support code uses them too. Thanks, M. --=20 Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html