From: Sudeep Holla <sudeep.holla@arm.com>
To: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"jaswinder.singh@linaro.org" <jaswinder.singh@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>
Subject: Re: [PATCH v7 1/8] PCC: Initialize PCC Mailbox earlier at boot
Date: Mon, 20 Jul 2015 15:20:01 +0100 [thread overview]
Message-ID: <55AD0391.2040504@arm.com> (raw)
In-Reply-To: <e5f53a07775cfb896688051b31acb2261ec1d3a2.1436464513.git.ashwin.chaugule@linaro.org>
On 09/07/15 19:04, Ashwin Chaugule wrote:
> This change initializes the PCC Mailbox earlier than
> the ACPI processor driver. This enables drivers introduced
> in follow up patches (e.g. CPPC) to be probed via the ACPI
> processor driver interface. The CPPC probe requires the PCC
> channel to be initialized for it to query each CPUs performance
> capabilities.
>
> Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
> Reviewed-by: Al Stone <al.stone@linaro.org>
> ---
> drivers/mailbox/pcc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index 7e91d68..fcda63e 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -352,4 +352,10 @@ static int __init pcc_init(void)
>
> return 0;
> }
> -device_initcall(pcc_init);
> +
> +/*
> + * Make pcc init postcore so that users of this mailbox
> + * such as the ACPI Processor driver have it available
> + * at their init.
> + */
> +postcore_initcall(pcc_init);
>
I assumed you have explored other options like deferred probe and
finally resorted to this as they are not feasible ? Because setting up
these kind of dependency are prone to create issues later on.
Regards,
Sudeep
next prev parent reply other threads:[~2015-07-20 14:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 18:04 [PATCH v7 0/8] CPUFreq driver using CPPC methods Ashwin Chaugule
2015-07-09 18:04 ` [PATCH v7 1/8] PCC: Initialize PCC Mailbox earlier at boot Ashwin Chaugule
2015-07-20 14:20 ` Sudeep Holla [this message]
2015-08-03 17:37 ` Ashwin Chaugule
2015-07-09 18:04 ` [PATCH v7 2/8] ACPI: Split out ACPI PSS from ACPI Processor driver Ashwin Chaugule
2015-07-18 0:01 ` Rafael J. Wysocki
2015-07-18 0:03 ` Rafael J. Wysocki
2015-08-03 17:26 ` Ashwin Chaugule
2015-08-03 17:24 ` Ashwin Chaugule
2015-07-20 14:20 ` Sudeep Holla
2015-07-20 21:59 ` Rafael J. Wysocki
2015-08-03 17:49 ` Ashwin Chaugule
2015-08-03 17:29 ` Ashwin Chaugule
2015-08-04 14:50 ` Sudeep Holla
2015-07-09 18:04 ` [PATCH v7 3/8] ACPI: Decouple ACPI idle and ACPI processor drivers Ashwin Chaugule
2015-07-20 14:21 ` Sudeep Holla
2015-08-03 17:40 ` Ashwin Chaugule
2015-08-04 14:51 ` Sudeep Holla
2015-08-04 14:58 ` Ashwin Chaugule
2015-08-04 15:18 ` Sudeep Holla
2015-08-04 15:44 ` Ashwin Chaugule
2015-08-04 17:00 ` Sudeep Holla
2015-08-05 13:47 ` Ashwin Chaugule
2015-07-09 18:04 ` [PATCH v7 4/8] ACPI: Introduce CPU performance controls using CPPC Ashwin Chaugule
2015-08-04 15:06 ` Sudeep Holla
2015-08-04 15:38 ` Ashwin Chaugule
2015-08-04 16:02 ` Sudeep Holla
2015-07-09 18:04 ` [PATCH v7 5/8] CPPC: Add a CPUFreq driver for use with CPPC Ashwin Chaugule
2015-07-20 14:22 ` Sudeep Holla
2015-07-20 22:07 ` Rafael J. Wysocki
2015-07-21 8:52 ` Sudeep Holla
2015-07-21 14:27 ` Rafael J. Wysocki
2015-07-21 15:32 ` Sudeep Holla
2015-07-09 18:04 ` [PATCH v7 6/8] ACPI: Add weak routines for ACPI CPU Hotplug Ashwin Chaugule
2015-07-09 18:04 ` [PATCH v7 7/8] CPPC: Probe for CPPC tables for each ACPI Processor object Ashwin Chaugule
2015-07-20 14:22 ` Sudeep Holla
2015-07-09 18:04 ` [PATCH v7 8/8] PCC: Enable PCC only when needed Ashwin Chaugule
2015-07-20 14:22 ` Sudeep Holla
2015-07-20 22:04 ` Rafael J. Wysocki
2015-07-21 9:23 ` Sudeep Holla
2015-07-21 14:34 ` Rafael J. Wysocki
2015-07-21 15:28 ` Sudeep Holla
2015-07-22 1:28 ` Rafael J. Wysocki
2015-07-22 8:59 ` Sudeep Holla
2015-08-03 17:35 ` Ashwin Chaugule
2015-08-04 14:53 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD0391.2040504@arm.com \
--to=sudeep.holla@arm.com \
--cc=ashwin.chaugule@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).