From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v7 1/8] PCC: Initialize PCC Mailbox earlier at boot Date: Mon, 20 Jul 2015 15:20:01 +0100 Message-ID: <55AD0391.2040504@arm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.101.70]:55935 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754225AbbGTOUF (ORCPT ); Mon, 20 Jul 2015 10:20:05 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Ashwin Chaugule Cc: "rjw@rjwysocki.net" , "jaswinder.singh@linaro.org" , Sudeep Holla , "linux-pm@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "patches@linaro.org" , "viresh.kumar@linaro.org" On 09/07/15 19:04, Ashwin Chaugule wrote: > This change initializes the PCC Mailbox earlier than > the ACPI processor driver. This enables drivers introduced > in follow up patches (e.g. CPPC) to be probed via the ACPI > processor driver interface. The CPPC probe requires the PCC > channel to be initialized for it to query each CPUs performance > capabilities. > > Signed-off-by: Ashwin Chaugule > Reviewed-by: Al Stone > --- > drivers/mailbox/pcc.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > index 7e91d68..fcda63e 100644 > --- a/drivers/mailbox/pcc.c > +++ b/drivers/mailbox/pcc.c > @@ -352,4 +352,10 @@ static int __init pcc_init(void) > > return 0; > } > -device_initcall(pcc_init); > + > +/* > + * Make pcc init postcore so that users of this mailbox > + * such as the ACPI Processor driver have it available > + * at their init. > + */ > +postcore_initcall(pcc_init); > I assumed you have explored other options like deferred probe and finally resorted to this as they are not feasible ? Because setting up these kind of dependency are prone to create issues later on. Regards, Sudeep