From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Date: Mon, 07 Sep 2015 16:32:05 +0100 Message-ID: <55EDADF5.5060008@arm.com> References: <1440022048-6285-1-git-send-email-al.stone@linaro.org> <1440022048-6285-2-git-send-email-al.stone@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.101.70]:51378 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbIGPcL (ORCPT ); Mon, 7 Sep 2015 11:32:11 -0400 In-Reply-To: <1440022048-6285-2-git-send-email-al.stone@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Al Stone , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Cc: Sudeep Holla , "linaro-kernel@lists.linaro.org" , "linux-ia64@vger.kernel.org" , "patches@linaro.org" , "linux-pm@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Len Brown Hi Al, On 19/08/15 23:07, Al Stone wrote: I finally got a chance to try this series on Juno. Well it exposed a firmware bug in MADT table :) [..] > acpi_tbl_entry_handler handler, > @@ -245,6 +484,8 @@ acpi_parse_entries(char *id, unsigned long table_size, > table_end) { > if (entry->type == entry_id > && (!max_entries || count < max_entries)) { > + if (bad_madt_entry(table_header, entry)) > + return -EINVAL; Not sure if we can have the above check here unconditionally. Currently I can see there are 2 other users of acpi_parse_entries i.e. PCC and NUMA. So may be it can be made conditional or return success for non-MADT tables from bad_madt_entry ? Other than that, you can add for ARM64 specific parts: Reviewed-and-tested-by: Sudeep Holla Regards, Sudeep