From: Timur Tabi <timur@codeaurora.org>
To: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>,
Matt Fleming <matt.fleming@intel.com>,
tony.luck@intel.com, fu.wei@linaro.org, al.stone@linaro.org,
rjw@rjwysocki.net, mchehab@osg.samsung.com, mingo@redhat.com,
bp@alien8.de, gong.chen@linux.intel.com
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org, vgandhi@codeaurora.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH V2 1/2] efi: print unrecognized CPER section
Date: Tue, 08 Sep 2015 16:56:57 -0500 [thread overview]
Message-ID: <55EF59A9.2010905@codeaurora.org> (raw)
In-Reply-To: <1441747761-12012-2-git-send-email-zjzhang@codeaurora.org>
On 09/08/2015 04:29 PM, Jonathan (Zhixiong) Zhang wrote:
> Change-Id: I663a6e3ae6dcf68e4e389f76d555e9106ffee165
You need to strip out the Change-Id's before posting the patch.
> +#define cper_print_hex(pfx, buf, len) \
> + print_hex_dump(pfx, "", \
> + DUMP_PREFIX_OFFSET, ROW_SIZE, GROUP_SIZE, \
> + buf, len, 0)
(buf), (len), 0)
is safer
> + } else {
> + const void *raw_err = gdata + 1;
> + printk("%ssection type: %pUl\n", pfx, sec_type);
> + printk("%ssection length: %d\n", pfx, len);
> + cper_print_hex(newpfx, raw_err, len);
You don't need raw_err. This should work fine:
cper_print_hex(newpfx, gdata + 1, len);
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2015-09-08 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 21:29 [PATCH V2 0/2] process unrecognized CPER error section Jonathan (Zhixiong) Zhang
[not found] ` <1441747761-12012-1-git-send-email-zjzhang-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-09-08 21:29 ` [PATCH V2 1/2] efi: print unrecognized CPER section Jonathan (Zhixiong) Zhang
2015-09-08 21:56 ` Timur Tabi [this message]
2015-09-10 18:27 ` Borislav Petkov
2015-09-08 21:29 ` [PATCH V2 2/2] ras: acpi / apei: generate trace event for " Jonathan (Zhixiong) Zhang
2015-09-10 18:41 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EF59A9.2010905@codeaurora.org \
--to=timur@codeaurora.org \
--cc=al.stone@linaro.org \
--cc=bp@alien8.de \
--cc=fu.wei@linaro.org \
--cc=gong.chen@linux.intel.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mchehab@osg.samsung.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=vgandhi@codeaurora.org \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).