From: Marc Zyngier <marc.zyngier@arm.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>,
Jason Cooper <jason@lakedaemon.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Tomasz Nowicki <tomasz.nowicki@linaro.org>,
Hanjun Guo <hanjun.guo@linaro.org>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Graeme Gregory <graeme@xora.org.uk>,
Jake Oshins <jakeo@microsoft.com>
Subject: Re: [PATCH v4 0/9] Making the generic ACPI GSI layer irqdomain aware
Date: Tue, 29 Sep 2015 18:17:57 +0100 [thread overview]
Message-ID: <560AC7C5.1090201@arm.com> (raw)
In-Reply-To: <CAL_Jsq+b10aEREipSsrg69=S4gpv-xZWRYS+TVTvhbqdHGATsA@mail.gmail.com>
On 29/09/15 18:11, Rob Herring wrote:
> On Mon, Sep 28, 2015 at 11:42 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> The irqdomain code is not entierely ACPI friendly, as it has some
>> built-in knowledge of the device-tree. Nothing too harmful, but enough
>> to scare the ARM ACPI developpers which end up with their own version
>> of the square wheel.
>>
>> This small patch series adapts the irqdomain code to remove the
>> hurdles that prevent the full blown irqdomain subsystem to be used on
>> ACPI, creates an interface between the GSI layer and the irqdomain,
>> and as an example, convert the ARM GIC ACPI support to use irqdomains
>> as originally intended.
>>
>> Overall, this gives us a way to use irqdomains on both DT and ACPI
>> enabled platforms, having very little changes made to the actual
>> drivers (other than the probing infrastructure). Because we keep the
>> flow of information between the various layers identical between ACPI
>> and DT, we immediately benefit from the existing infrastructure. The
>> "convert the GSI information to be DT friendly" is admitedly not very
>> pretty, but I see it as a stepping stone towards unifying the two
>> structures.
>
> Did I miss v1-v3 or did the DT change just show up? I probably tuned
> out with ACPI in the subject.
No, that's new. It was far worse before.
> Needing fake DT nodes for ACPI is just wrong. There's got to be
> another, better way.
Well, the alternative is to rewrite the whole of irqdomain and
everything that gets called from there in terms of fwnode_handle. Which
will trickle in the whole of OF as well.
Note that the fake DT node doesn't represent an ACPI object at all. It
is an identifier for an irqdomain, and that's where it stops.
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2015-09-29 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 16:42 [PATCH v4 0/9] Making the generic ACPI GSI layer irqdomain aware Marc Zyngier
2015-09-28 16:42 ` [PATCH v4 1/9] drivers/of: Introduce of_node_alloc Marc Zyngier
2015-09-28 22:50 ` Frank Rowand
[not found] ` <5609C43E.1040106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-29 8:01 ` Marc Zyngier
2015-09-28 16:42 ` [PATCH v4 2/9] genirq/irqdomain: Add irq_create_acpi_mapping Marc Zyngier
2015-09-28 16:42 ` [PATCH v4 3/9] genirq/irqdomain: Add a fwnode_handle allocator Marc Zyngier
2015-09-28 16:42 ` [PATCH v4 4/9] acpi/gsi: Always perform an irq domain lookup Marc Zyngier
2015-09-28 16:42 ` [PATCH v4 5/9] acpi/gsi: Add acpi_set_irq_model to initialize the GSI layer Marc Zyngier
2015-09-28 16:42 ` [PATCH v4 6/9] acpi/gsi: Select OF_DYNAMIC when ACPI_GENERIC_GSI is selected Marc Zyngier
2015-09-28 16:43 ` [PATCH v4 7/9] irqchip/GIC: Get rid of gic_init_bases() Marc Zyngier
2015-09-28 16:43 ` [PATCH v4 8/9] irqchip/GIC: Switch ACPI support to stacked domains Marc Zyngier
2015-09-28 16:43 ` [PATCH v4 9/9] acpi/gsi: Cleanup acpi_register_gsi Marc Zyngier
[not found] ` <1443458582-7497-1-git-send-email-marc.zyngier-5wv7dgnIgG8@public.gmane.org>
2015-09-29 17:11 ` [PATCH v4 0/9] Making the generic ACPI GSI layer irqdomain aware Rob Herring
2015-09-29 17:17 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560AC7C5.1090201@arm.com \
--to=marc.zyngier@arm.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=graeme@xora.org.uk \
--cc=hanjun.guo@linaro.org \
--cc=jakeo@microsoft.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=tglx@linutronix.de \
--cc=tomasz.nowicki@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).