From: Prarit Bhargava <prarit@redhat.com>
To: "Zheng, Lv" <lv.zheng@intel.com>,
"Moore, Robert" <robert.moore@intel.com>,
"devel@acpica.org" <devel@acpica.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
Date: Fri, 09 Oct 2015 07:29:41 -0400 [thread overview]
Message-ID: <5617A525.2070806@redhat.com> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BAC67EE@SHSMSX101.ccr.corp.intel.com>
On 10/09/2015 01:26 AM, Zheng, Lv wrote:
> Please ignore this.
> The fix is against the caller.
>
> Thanks and best regards
> -Lv
>
>> -----Original Message-----
>> From: Devel [mailto:devel-bounces@acpica.org] On Behalf Of Zheng, Lv
>> Sent: Friday, October 09, 2015 10:02 AM
>> To: Prarit Bhargava; Moore, Robert; devel@acpica.org
>> Cc: linux-acpi@vger.kernel.org; Wysocki, Rafael J
>> Subject: Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
>>
>> Why don't you fix this in the invoker side?
>> For example:
>> If (acpi_get_handle())
>> acpi_evaluate_object()
That seems like a sloppy workaround an actual bug in ACPICA.
>> So that the AE_NOT_FOUND warning can still be kept for the real troubles?
The code is warning 100% of the time on something that is optional.
>> There are really scenarios that such warning is useful for catching bugs.
>>
What scenario is possible where this causes a problem? Issuing an error on
something that is optional is not a good idea.
P.
next prev parent reply other threads:[~2015-10-09 11:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 17:28 [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning Prarit Bhargava
2015-10-01 17:57 ` Moore, Robert
2015-10-01 22:28 ` Rafael J. Wysocki
2015-10-07 15:28 ` Prarit Bhargava
2015-10-07 15:52 ` Moore, Robert
2015-10-07 15:57 ` Prarit Bhargava
2015-10-07 16:27 ` Moore, Robert
2015-10-07 18:50 ` [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2] Prarit Bhargava
2015-10-08 14:19 ` Moore, Robert
2015-10-08 14:23 ` Prarit Bhargava
2015-10-09 2:02 ` Zheng, Lv
2015-10-09 5:26 ` Zheng, Lv
2015-10-09 11:29 ` Prarit Bhargava [this message]
2015-10-09 14:04 ` Moore, Robert
2015-10-10 1:22 ` Zheng, Lv
2015-10-10 1:37 ` Zheng, Lv
2015-10-13 20:59 ` Moore, Robert
2015-10-14 1:47 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5617A525.2070806@redhat.com \
--to=prarit@redhat.com \
--cc=devel@acpica.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).