From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Stone Subject: Re: [Linaro-acpi] [PATCH v5 0/5] Provide better MADT subtable sanity checks Date: Mon, 12 Oct 2015 14:52:23 -0600 Message-ID: <561C1D87.8010106@linaro.org> References: <1443570346-15378-1-git-send-email-al.stone@linaro.org> <560BA4C9.7090607@huawei.com> <560C0968.6020904@redhat.com> <2808057.teMg2oCLf6@vostro.rjw.lan> <5612AF64.4060900@redhat.com> <561B2442.9050600@erley.org> <561B2DAD.5070601@linaro.org> <561B2FCA.1010504@erley.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-io0-f171.google.com ([209.85.223.171]:36252 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbbJLUw0 (ORCPT ); Mon, 12 Oct 2015 16:52:26 -0400 Received: by ioii196 with SMTP id i196so882054ioi.3 for ; Mon, 12 Oct 2015 13:52:26 -0700 (PDT) In-Reply-To: <561B2FCA.1010504@erley.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Pat Erley , Hanjun Guo , Al Stone , "Rafael J. Wysocki" Cc: linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org, linaro-acpi@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, patches@linaro.org, Hanjun Guo , linux-arm-kernel@lists.infradead.org On 10/11/2015 09:58 PM, Pat Erley wrote: > On 10/11/2015 08:49 PM, Hanjun Guo wrote: >> On 10/12/2015 11:08 AM, Pat Erley wrote: >>> On 10/05/2015 10:12 AM, Al Stone wrote: >>>> On 10/05/2015 07:39 AM, Rafael J. Wysocki wrote: >>>>> On Wednesday, September 30, 2015 10:10:16 AM Al Stone wrote: >>>>>> On 09/30/2015 03:00 AM, Hanjun Guo wrote: >>>>>>> On 2015/9/30 7:45, Al Stone wrote: >>>>>>>> NB: this patch set is for use against the linux-pm bleeding edge >>>>>>>> branch. >>>>>>>> >>>>>> >>>>>> [snip...] >>>>>> >>>>>>> >>>>>>> For this patch set, >>>>>>> >>>>>>> Reviewed-by: Hanjun Guo >>>>>>> >>>>>>> Thanks >>>>>>> Hanjun >>>>>> >>>>>> Thanks, Hanjun! >>>>> >>>>> Series applied, thanks! >>>>> >>>>> Rafael >>>>> >>>> >>>> Thanks, Rafael! >>>> >>> >>> Just decided to test out linux-next (to see the new nouveau cleanups). >>> This change set prevents my Lenovo W510 from booting properly. >>> >>> Reverting: 7494b0 "ACPI: add in a bad_madt_entry() function to >>> eventually replace the macro" >>> >>> Gets the system booting again. I'm attaching my dmesg from the failed >>> boot, who wants the acpidump? >> >> [ 0.000000] ACPI: undefined version for either FADT 4.0 or MADT 1 >> [ 0.000000] ACPI: Error parsing LAPIC address override entry >> [ 0.000000] ACPI: Invalid BIOS MADT, disabling ACPI >> >> Seems the MADT revision is not right, could you dump the ACPI MADT >> (APIC) table and send it out? I will take a look :) >> >> Thanks >> Hanjun > > Here ya go, enjoy. Feel free to CC me on any patches that might fix it. Pat, Would you mind sending a copy of the FADT, also, please? The first of the ACPI messages is a check of version correspondence between the FADT and MADT, while the second message is from looking at just an MADT subtable. Thanks for sending the MADT out -- that helps me quite a lot in thinking this through. BTW, whoever is providing the BIOS (Lenovo, I assume) may want to have a look at these, also: [ 0.000000] ACPI BIOS Warning (bug): 32/64X length mismatch in FADT/Pm1aControlBlock: 16/32 (20150818/tbfadt-623) [ 0.000000] ACPI BIOS Warning (bug): Invalid length for FADT/Pm1aControlBlock: 32, using default 16 (20150818/tbfadt-704) Not inherently dangerous, but definitely sloppy and mind-numbingly easy to avoid, IIRC. -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org -----------------------------------