From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
To: Tomasz Nowicki <tn@semihalf.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
marc.zyngier@arm.com, tglx@linutronix.de, jason@lakedaemon.net,
rjw@rjwysocki.net
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
hanjun.guo@linaro.org, graeme.gregory@linaro.org, dhdang@apm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m ACPI support
Date: Thu, 15 Oct 2015 08:29:42 +0200 [thread overview]
Message-ID: <561F47D5.6070601@linaro.org> (raw)
In-Reply-To: <561F449E.2050803@semihalf.com>
On 15.10.2015 08:15, Tomasz Nowicki wrote:
> Hi Suravee,
>
[...]
> Moreover, seems we need to add irq_domain_free_fwnode to gicv2m_teardown():
> static void gicv2m_teardown(void)
> {
> struct v2m_data *v2m, *tmp;
>
> list_for_each_entry_safe(v2m, tmp, &v2m_nodes, entry) {
> + struct fwnode_handle *handle = v2m->fwnode;
> +
> list_del(&v2m->entry);
> kfree(v2m->bm);
> iounmap(v2m->base);
> - of_node_put(to_of_node(v2m->fwnode));
> + if (is_of_node(handle))
> + of_node_put(to_of_node(handle));
> + else if (is_irqchip_node(handle))
> + irq_domain_free_fwnode(handle);
> kfree(v2m);
> }
> }
>
Sorry, I missed you already did something similar in your patch.
Tomasz
next prev parent reply other threads:[~2015-10-15 6:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 23:25 [PATCH V2 0/6] gicv2m: acpi: Add ACPI support for GICv2m MSI Suravee Suthikulpanit
2015-10-14 23:25 ` [PATCH V2 1/6] pci: msi: Add support to query MSI domain for pci device Suravee Suthikulpanit
2015-10-14 23:25 ` [PATCH V2 2/6] acpi: pci: Setup MSI domain for ACPI based pci devices Suravee Suthikulpanit
2015-10-14 23:25 ` [PATCH V2 3/6] irqdomain: introduce is_fwnode_irqchip helper Suravee Suthikulpanit
2015-10-14 23:25 ` [PATCH V2 4/6] irqdomain: Introduce irq_domain_get_irqchip_fwnode_name helper function Suravee Suthikulpanit
2015-10-14 23:25 ` [PATCH V2 5/6] gicv2m: Refactor to prepare for ACPI support Suravee Suthikulpanit
2015-10-14 23:25 ` [PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m " Suravee Suthikulpanit
2015-10-15 6:15 ` Tomasz Nowicki
2015-10-15 6:29 ` Tomasz Nowicki [this message]
2015-10-15 14:03 ` Suravee Suthikulanit
2015-10-15 14:30 ` Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561F47D5.6070601@linaro.org \
--to=tomasz.nowicki@linaro.org \
--cc=Catalin.Marinas@arm.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=dhdang@apm.com \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).